WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 7 weeks ago

#45967 closed defect (bug) (wontfix)

PHP Standards and Docblocks for class-ftp.php

Reported by: bhubbard Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Filesystem API Keywords:
Focuses: docs Cc:

Description

I notice class-ftp.php did not have any docblocks. I have a patch here that improves documentation and fixes many of the php standards issues.

Attachments (1)

45967.diff (89 bytes) - added by bhubbard 18 months ago.
PHP Standards & Documentation Improvements.

Download all attachments as: .zip

Change History (9)

@bhubbard
18 months ago

PHP Standards & Documentation Improvements.

#2 @pento
18 months ago

  • Version trunk deleted

#3 @desrosj
18 months ago

  • Focuses docs added
  • Keywords has-patch needs-refresh added

Hi @bhubbard! Thanks for this ticket. 45967.diff does not appear to be in the correct format and your Gist appears to be the entire file. Are you able to refresh into a proper patch for consideration? You can find more information about how to accomplish this on the Working with Patches page of the WordPress Core Handbook.

#4 @desrosj
18 months ago

  • Type changed from enhancement to defect (bug)

This ticket was mentioned in PR #182 on WordPress/wordpress-develop by bhubbard.


4 months ago

Just some docblocks and PHP Coding Standards for the FTP Pure class file.

Trac ticket: https://core.trac.wordpress.org/ticket/45967

This ticket was mentioned in PR #183 on WordPress/wordpress-develop by bhubbard.


4 months ago

General php standards improvements, and docblocks for class-ftp-sockets.php.

Trac ticket: https://core.trac.wordpress.org/ticket/45967

This ticket was mentioned in PR #184 on WordPress/wordpress-develop by bhubbard.


4 months ago

Lots of php coding standards fixes for class-ftp.php.

Trac ticket: https://core.trac.wordpress.org/ticket/45967

#8 @ocean90
7 weeks ago

  • Keywords has-patch needs-refresh removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The FTP classes are part of an external library and doesn't need to follow WordPress coding standards. It’s also excluded in our PHP Code Sniffer config, see phpcs.xml.dist.

Related: #49596

Note: See TracTickets for help on using tickets.