extend get_search_form() to allow placeholder text to be passed into method

[gege90ererefeee]

Desire:
get_search_form('Search here...');

Output
<input type="submit" id="searchsubmit" value="Search" placeholder="Search here...">

To allow the developer to manually set a placeholder text when invoking the native wp search form. This removes the need for unnecessary JS, php methods to override, or creating a searchform.php file just to set a placeholder text.

[sebastienserre]

Hello @gege90ererefeee,

Many thanks for your great idea, I attached a patch with this.

[sebastienserre]

drink some coffe and improve the patch!

[swissspidy]

Related discussion: #40462

[afercia]

Related: #40331

[mukesh27]

Updated Patch.

[afercia]

Worth noting this function prints out also a visually hidden label for the search input:

<label>
	<span class="screen-reader-text">' . _x( 'Search for:', 'label' ) . '</span>
	...

When changing the placeholder, the visually hidden label should still make sense, which makes things a bit more complicated.

@gege90ererefeee any more use cases other than having the ability to change Search... to Search here..?

[afercia]

Discussed during today's accessibility bug scrub and agreed to close this ticket. Also, no reporter feedback in a month. Discussion can always continue on closed tickets :)