Opened 6 years ago
Closed 6 years ago
#45973 closed enhancement (duplicate)
Wrap global functions like __() in 'function_exists' condition
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | trivial | Version: | |
Component: | I18N | Keywords: | |
Focuses: | Cc: |
Description
The () function is used in multiple frameworks and other open source libraries.
When both systems (e.g. WordPress and Laravel or WordPress and Magento) are required in one composer project the 'function already exists' Exception got thrown.
To override the function behaviour and/or be compatible with other frameworks like Laravel the functions should be wrapped within a 'function_exists' condition like so:
<?php if (! function_exists('__')) { function __( $text, $domain = 'default' ) { return translate( $text, $domain ); } }
Especially the Laravel core does the same: https://github.com/laravel/framework/blob/5.7/src/Illuminate/Foundation/helpers.php
Attachments (2)
Change History (3)
Note: See
TracTickets for help on using
tickets.
Patch