WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 1 and Version 5 of Ticket #45985


Ignore:
Timestamp:
12/21/2022 05:52:53 PM (2 years ago)
Author:
sabernhardt
Comment:

(I corrected the link to GB11973, which was not merged)

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #45985 – Description

    v1 v5  
    2626https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentyseventeen/functions.php#L491-L517
    2727
    28 At the time of writing, this issue is blocked by Gutenberg: We can currently issue a custom `sizes` attribute for non-aligned images like the example above, but it is not currently possible to have the theme customize the `sizes` attritbute for full/wide images. See the following GitHub issues for reference:
     28At the time of writing, this issue is blocked by Gutenberg: We can currently issue a custom `sizes` attribute for non-aligned images like the example above, but it is not currently possible to have the theme customize the `sizes` attribute for full/wide images. See the following GitHub issues for reference:
    2929
    3030https://github.com/WordPress/gutenberg/issues/6131
    … …  
    4242https://github.com/WordPress/twentynineteen/pull/701
    4343
    44 https://core.trac.wordpress.org/attachment/ticket/45985/45985-regular-images.patch
     44[attachment:"45985-regular-images.patch"]
    4545
    46 **Adding custom `sizes` attributes, including `wide` and `full` variants** (This is dependent on Gutenberg #11973 being merged):
     46**Adding custom `sizes` attributes, including `wide` and `full` variants** (This is dependent on [https://github.com/WordPress/gutenberg/pull/11973 Gutenberg #11973] being merged):
    4747
    4848https://github.com/WordPress/twentynineteen/pull/629
    4949
    50 https://core.trac.wordpress.org/attachment/ticket/45985/45985-all-images.patch
     50[attachment:"45985-all-images.patch"]