WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#45999 closed feature request (fixed)

Remove privacy pointers again

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: desrosj's profile desrosj
Milestone: 5.2 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch commit
Focuses: Cc:

Description

This ticket is to trac the discussion on timeline for removing the wp496_privacy pointer.

As @desrosj indicated we'll need to look historically how long pointers lifespans have been and decide upon a timeline and release for deprecating the Privacy pointer.
Reference - https://core.trac.wordpress.org/ticket/45529#comment:11

As 5.1 RC is impending I would assume this would be 5.2+ unless it becomes a blessed task (leaving that decision to others..

Attachments (1)

45999.diff​ (2.3 KB) - added by desrosj 6 years ago.

Download all attachments as: .zip

Change History (14)

#1 @Luciano Croce
6 years ago

  • Keywords dev-feedback added
  • Severity changed from normal to blocker

IMHO Privacy Pointer is very nagging for users in backend.

In general is very nagging as well for all other usages in backend.

I suggest to totally remove it for all usages!

#2 @swissspidy
6 years ago

  • Severity changed from blocker to normal
  • Summary changed from Ticket for removal of the Privacy Pointer in a future release to Remove privacy pointers again

This ticket was mentioned in ​Slack in #core-privacy by garrett-eclipse. ​View the logs.
6 years ago

This ticket was mentioned in ​Slack in #core-privacy by garrett-eclipse. ​View the logs.
6 years ago

This ticket was mentioned in ​Slack in #core-privacy by desrosj. ​View the logs.
6 years ago

#6 @dejliglama
6 years ago

  • Keywords needs-patch added

#7 @desrosj
6 years ago

  • Keywords 2nd-opinion dev-feedback removed
  • Milestone changed from Future Release to 5.2
  • Owner set to desrosj
  • Status changed from new to assigned

Let's remove this in 5.2. There are a few issues with the implementation (#44136), and 5.2 will be the third major release after the feature was introduced in 4.9.6.

This ticket was mentioned in ​Slack in #core-privacy by desrosj. ​View the logs.
6 years ago

@desrosj
6 years ago

#9 @desrosj
6 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

45999.diff​ removes the privacy pointer added in 4.9.6.

#10 @xkon
6 years ago

Looks fine to me @desrosj , I just want to add that when we implemented these pointers we've added a small css addition as well https://core.trac.wordpress.org/attachment/ticket/43942/43942.3.diff at src/wp-includes/css/wp-pointer.css.

I'm guessing that stays though as an overall addition, correct?

#11 @desrosj
6 years ago

  • Keywords commit added; needs-testing removed

Ya, I think that style can remain.

#12 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44787:

Privacy: Remove privacy feature related admin pointers.

In 4.9.6, several new privacy related features were introduced. Admin pointers were included to make administrators aware of these features. They have served their purpose and can now go silently into the night.

Props garrett-eclipse, desrosj, xkon.
Fixes #45999.

#13 @garrett-eclipse
6 years ago

Nicely done @desrosj this looks good.

Note: See TracTickets for help on using tickets.