WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#46024 closed defect (bug) (fixed)

Make version_compare for Servehappy more robust

Reported by: afragen's profile afragen Owned by: flixos90's profile flixos90
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Site Health Keywords: has-patch servehappy dev-feedback needs-testing
Focuses: Cc:

Description

As discussed in #core-php ​https://wordpress.slack.com/archives/C60K3MP2Q/p1546880250090100 there's a potential problem with the current version_compare for testing compatibility with WordPress or PHP version numbers.

Using the current test version_compare( substr( phpversion(), 0, strlen( $requires ) ), $requires, '>=' ) if the current version is 5.1.10 and the required version is 5.1.2, the above will evaluate to false when it should be true.

Simplifying the test to version_compare( phpversion(), $requires, '>=' ) evaluates to true, as it should.

This test was added in r43436

Attachments (1)

46024.diff​ (2.5 KB) - added by afragen 6 years ago.
adjust version_compare logic

Download all attachments as: .zip

Change History (6)

@afragen
6 years ago

adjust version_compare logic

#1 @swissspidy
6 years ago

  • Milestone changed from Awaiting Review to 5.1

This ticket was mentioned in ​Slack in #core-php by afragen. ​View the logs.
6 years ago

#3 @flixos90
6 years ago

  • Owner set to flixos90
  • Status changed from new to reviewing

#4 @flixos90
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 44656:

Upgrade/Install: Make version_compare() calls for plugin required version checks more robust.

Props afragen.
Fixes #46024. See #43986.

#5 @spacedmonkey
6 years ago

  • Component changed from Upgrade/Install to Site Health
Note: See TracTickets for help on using tickets.