Opened 2 years ago
Last modified 3 weeks ago
#46032 reviewing defect (bug)
Plugin details text direction layout (RTL)
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Plugins | Keywords: | has-patch has-screenshots |
Focuses: | css, rtl, administration | Cc: |
Description
Hi,
This RTL CSS minor was noticed before 5.0 release, but with increasing number of plugins that have been translated to RTL languages! It would be nice fix it at present.
In the plugin details screen, when site language or admin choosing RTL panel:
Text direction for plugin Description, Changelog, Screenshots captions, and Reviews tabs appears LTR and some phrases become not quickly understood.
(Screenshot attached https://moqbel.net/s/WP-admin-plugins-description-RTL-PrtScn).
In this case (especially for those plugins that have been translated to any RTL language) I think the following needs to be fixed:
direction: ltr;
#plugin-information .section { direction: rtl; }
And for section ul class:
margin-left: 24px;
#plugin-information .section ol, #plugin-information .section ul { list-style-type: disc; margin-right: 24px; }
For Reviews tab (RTL):
- star-rating:
float: left;
#plugin-information .reviewer-info .star-rating { float: right; }
- review-title-section h4
float: left;
margin: 0 6px 0 0;
#plugin-information .review-title-section h4 { display: inline-block; float: right; margin: 0 0 0 6px; }
- reviewer-info .avatar
float: left;
margin: 4px 6px 0 0;
#plugin-information .reviewer-info .avatar { float: right; margin: 4px 0 0 6px; }
Finally will be displayed correctly as this PrtScn:
https://moqbel.net/s/WP-admin-plugins-description-RTL-PrtScn-fixed
Many thanks,
Attachments (4)
Change History (15)
#1
@
2 years ago
- Component changed from Administration to Plugins
- Keywords has-screenshots added
Hi @nabilmoqbel, Welcome to WordPres Trac! Thanks for the report.
Good catch.
#4
@
23 months ago
Hi, we have discussion before on Slack, thanks @dd32 for your time,
About the idea of adding a flag for RTL whether “readme is translated”.
Because even in that case of those plugins NOT translated ltr
, it is quite clear, still be readable and does not change the meaning for any sentences.
But if any plugin even if one word translated, that sentence will become not clearly understood (As shown in the old image above).
For plugin name direction, is correct (Although the name does not show a problem on plugin header, even if it is not translated).
#6
@
7 months ago
- Milestone changed from Awaiting Review to 5.6
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
4 months ago
#8
@
4 months ago
- Milestone changed from 5.6 to 5.7
Didn't get a chance to review this in time for 5.6, moving to the next release for now.
This ticket was mentioned in Slack in #core by sabernhardt. View the logs.
2 months ago
#10
@
2 months ago
- Focuses css added
Without the rtl:ignore
comments for list-style-type
and display
properties, I still get the same results in RTL. So 46032.2.patch removes those two comments, and the patch applies to the root directory.
Plugins description RTL