Opened 7 years ago
Last modified 2 months ago
#46055 new defect (bug)
Twenty Seventeen: Blockquotes aligned right are not rechecked when widgets are added in the Customizer
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Future Release | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Bundled Theme | Keywords: | needs-patch has-screenshots |
| Focuses: | javascript | Cc: |
Description
While working on testing #40103 using the Customizer I discovered that when a widget is added, removed, or updated in the sidebar Twenty Seventeen does not recheck that the sidebar is empty enough to push the blockquote to the right.
To reproduce:
- Create a post with a blockquote two or three paragraphs down the page.
- Give the blockquote the
alignrightclass. - Remove widgets from the sidebar so that there is only one (none works too).
- Open the Customizer.
- You should see the example image posted on #40103.
- Add or change widgets in the sidebar to make the height of the sidebar pass the blockquote.
The content will overlap the blockquote and it will not be pushed back into the content area as it should.
Attachments (1)
Change History (5)
#4
@
2 months ago
belowEntryMetaClass() updates whether the right-aligned blockquote (including the Quote block) should have the below-entry-meta class when the page reloads or resizes. Because it does not run as the Blog Sidebar widget content is changed, adding content can result in a temporary overlap in the Customizer. Similarly, reducing the widget content would not move the quote into the empty space until the page is reloaded or resized.
I thought the script function could simply skip running in the Customizer
(by adding $body.hasClass( 'twentyseventeen-customizer' ) to the list of conditions to return).
That would avoid the overlap, but it would be a little inaccurate when the widget content is short, even after reloading or resizing the page.
Blockquote being overlapped by gallery widget added in the Customizer without resizing the window after.