WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#46056 closed defect (bug) (fixed)

The personal data export email for privacy requests should be in the users locale

Reported by: garrett-eclipse Owned by: garrett-eclipse
Milestone: 5.2 Priority: normal
Severity: normal Version: 4.9.6
Component: I18N Keywords: has-patch has-unit-tests
Focuses: administration, privacy Cc:

Description

Hello,

From testing in #44721 we found that the second email sent to the user (the fulfillment email) is not in their locale but it should be.

Example from @birgire - https://core.trac.wordpress.org/attachment/ticket/44721/user-fullfilment-email.jpg

Attachments (8)

Screen Shot 2019-01-21 at 1.58.33 PM.png (91.9 KB) - added by garrett-eclipse 3 years ago.
Export Fulfillment email that should be in user locale
46056.diff (1.1 KB) - added by garrett-eclipse 3 years ago.
Patch to make Erasure fulfillment emails in users locale
46056.2.diff (9.8 KB) - added by garrett-eclipse 3 years ago.
Added Unit Tests following the convention set in #44721
de_DE.mo (777 bytes) - added by garrett-eclipse 3 years ago.
.mo binary for testing de_DE as svn diff doesn't support
es_ES.mo (935 bytes) - added by garrett-eclipse 3 years ago.
.mo binary for testing es_ES as svn diff doesn't support
46056.3.diff (9.3 KB) - added by garrett-eclipse 3 years ago.
Refresh to account for #44721 being committed - Changed are isolated to .po test files. .mo versions coming shortly
de_DE.2.mo (863 bytes) - added by garrett-eclipse 3 years ago.
Refreshed de_DE.mo due to #44721
es_ES.2.mo (1.0 KB) - added by garrett-eclipse 3 years ago.
Refresh of es_ES.mo due to #44721

Download all attachments as: .zip

Change History (19)

@garrett-eclipse
3 years ago

Export Fulfillment email that should be in user locale

#1 @dejliglama
3 years ago

  • Version 4.9.6 deleted

While waiting for Berlin (and the rest of the roadmap), a ticket like this which i think we can all agree - is a good idea, could be expedited.

#2 @desrosj
3 years ago

  • Milestone changed from Awaiting Review to Future Release

@garrett-eclipse
3 years ago

Patch to make Erasure fulfillment emails in users locale

#3 @garrett-eclipse
3 years ago

  • Keywords has-patch needs-testing needs-unit-tests added; needs-patch removed
  • Milestone changed from Future Release to 5.2
  • Owner set to garrett-eclipse
  • Status changed from new to accepted
  • Version set to 4.9.6

Mimicking @birgire's successful patch (44721-2.diff) from #44721 I've applied the same logic into the wp_privacy_send_personal_data_export_email function found in file.php to create patch 46056.diff.

#4 @desrosj
3 years ago

  • Summary changed from The fulfillment emails for export and erasure privacy requests should be in the users locale to The fulfillment email for export privacy requests should be in the users locale

@garrett-eclipse
3 years ago

Added Unit Tests following the convention set in #44721

@garrett-eclipse
3 years ago

.mo binary for testing de_DE as svn diff doesn't support

@garrett-eclipse
3 years ago

.mo binary for testing es_ES as svn diff doesn't support

#5 @garrett-eclipse
3 years ago

  • Keywords has-unit-tests added; needs-unit-tests removed
  • Summary changed from The fulfillment email for export privacy requests should be in the users locale to The personal data export email for privacy requests should be in the users locale

Uploaded 46056.2.diff to provide unit tests which follow the same as was laid out in #44721. Attached .mo files should be placed in the tests/phpunit/data/languages folder as they couldn't be included in the svn diff, their .po counterparts are there.
*This will require a refresh once #44721 is committed

#6 @garrett-eclipse
3 years ago

  • Component changed from Privacy to I18N
  • Focuses privacy added

Updated component/focus to match it's sister ticket #44721

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


3 years ago

@garrett-eclipse
3 years ago

Refresh to account for #44721 being committed - Changed are isolated to .po test files. .mo versions coming shortly

@garrett-eclipse
3 years ago

Refreshed de_DE.mo due to #44721

@garrett-eclipse
3 years ago

Refresh of es_ES.mo due to #44721

#8 @garrett-eclipse
3 years ago

Refreshed the .po and .mo files due to #44721 being committed to trunk 🎉.
Note to testers and committers: For successful unit tests place the de_DE.2.mo and es_ES.2.mo into the .../tests/phpunit/data/languages folder as de_DE.mo and es_ES.mo respectively.
*Sorry can't include in svn diff due to binary files being excluded from diffs.

#9 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 45062:

Privacy: Ensure the personal data export email is sent in the locale of the user whose data is being exported (or the site's default locale if they are not a registered user) when the administrator fulfilling the request uses a different locale.

Props garrett-eclipse.
Fixes #46056.

#10 @garrett-eclipse
3 years ago

  • Keywords needs-testing removed

Thanks @SergeyBiryukov greatly appreciate the review and commit. Cheers

#11 @SergeyBiryukov
3 years ago

In 45063:

PHPCS: Fix WPCS violations in [45062].

See #46056.

Note: See TracTickets for help on using tickets.