Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#46068 closed defect (bug) (invalid)

Fatal error in a mu-plugin causes WSoD protection handler to trigger a warning

Reported by: johnbillion Owned by: flixos90
Priority: normal Milestone:
Component: Site Health Version: 5.1
Severity: normal Keywords: servehappy has-patch
Cc: Focuses:

Description

Given a mu-plugin that triggers a fatal error immediately upon execution, the WSoD protection handler additionally triggers a warning of its own:

Warning: Invalid argument supplied for foreach() in wp-includes/error-protection.php on line 71

The $wp_theme_directories has not been populated at this early point, and therefore triggers this error.

Attachments (1)

46068.diff (609 bytes ) - added by flixos90 8 years ago.

Download all attachments as: .zip

Change History (10)

#1 @flixos90
8 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone Awaiting Review5.1
  • Owner set to flixos90
  • Status newassigned

@flixos90
8 years ago

#2 @flixos90
8 years ago

  • Resolutionfixed
  • Status assignedclosed

In 44706:

Bootstrap/Load: Fix notice when theme directories are not populated yet.

When a fatal error occurs outside of a regular plugin in a stage where theme directories are not set up yet (for example in a MU plugin), this would previously trigger a notice.

Props johnbillion.
Fixes #46068. See #44458.

#3 @flixos90
8 years ago

In 44717:

Bootstrap/Load: Revert fatal error recovery mechanism from 5.1 to polish for 5.2.

Due to the high number of follow-up tickets and associated security concerns, it was decided to reschedule the fatal error recovery feature for WordPress 5.2, in order to address these issues properly. The feature will continue to be developed, with iterations being merged into trunk early in the 5.2 release cycle.

Fixes #46141. See #44458, #45932, #45940, #46038, #46047, #46068.

#4 @flixos90
8 years ago

  • Resolution fixed
  • Status closedreopened

#5 @flixos90
8 years ago

  • Milestone 5.15.2

#6 @flixos90
8 years ago

  • Priority lownormal

#7 @flixos90
7 years ago

  • Milestone 5.25.3

#8 @flixos90
7 years ago

  • Milestone 5.3
  • Resolutioninvalid
  • Status reopenedclosed

This ticket is based on the old fatal error recovery mode implementation and will be covered as part of #46130.

#9 @spacedmonkey
7 years ago

  • Component Bootstrap/LoadSite Health
Note: See TracTickets for help on using tickets.