WordPress.org

Make WordPress Core

Opened 22 months ago

Closed 7 weeks ago

#46079 closed enhancement (duplicate)

Replace "This link has expired" error message

Reported by: utsav72640 Owned by: garrett-eclipse
Milestone: Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch commit
Focuses: ui-copy Cc:

Description

Please a Replace text of 'This link has expired.' with 'Request link has expired.'

Attachments (2)

user.php.patch (506 bytes) - added by utsav72640 22 months ago.
/wp-includes/user.php
46079.2.diff (507 bytes) - added by garrett-eclipse 2 months ago.
Updated patch to provide full clarity and parity with #51351 using 'This user privacy request has expired.'

Download all attachments as: .zip

Change History (10)

@utsav72640
22 months ago

/wp-includes/user.php

#1 @utsav72640
22 months ago

  • Focuses ui accessibility added

#2 follow-up: @subrataemfluence
22 months ago

  • Keywords close added; has-patch removed

I don't think this change is really required here. If one user is requesting a link and it is expired, it is well understood that the same link is referred by "This".

So I personally feel replacing This by Request does not add any additional value here.

Last edited 22 months ago by subrataemfluence (previous) (diff)

#3 in reply to: ↑ 2 @mukesh27
22 months ago

  • Focuses ui accessibility removed
  • Keywords wantfix added

@subrataemfluence +1 Text change is not added any additional value for that text.

Replying to subrataemfluence:

I don't think this change is really required here. If one user is requesting a link and it is expired, it is well understood that the same link is referred by "This".

So I personally feel replacing This by Request does not add any additional value here.

#4 @utsav72640
22 months ago

  • Keywords has-patch added

As per links documentation standard avoid generic text. and use the field name.

#5 @desrosj
18 months ago

  • Focuses privacy added
  • Keywords 2nd-opinion added; wantfix removed

Marking for a second opinion.

#6 @garrett-eclipse
10 months ago

  • Component changed from Text Changes to Privacy
  • Focuses ui-copy added; privacy removed

@garrett-eclipse
2 months ago

Updated patch to provide full clarity and parity with #51351 using 'This user privacy request has expired.'

#7 @garrett-eclipse
2 months ago

  • Keywords commit added; close 2nd-opinion removed
  • Milestone changed from Awaiting Review to 5.6
  • Owner set to garrett-eclipse
  • Status changed from new to accepted
  • Version set to 4.9.6

Thanks for the feedback and patch @utsav72640 I also came across this string while improving clarity via #51351. As that ticket will probably take longer and I didn't want to just close this one and lose your contribution I've refreshed your patch in 46079.2.diff to use the new clearer string;
'This user privacy request has expired.'

Moving this forward.

#8 @SergeyBiryukov
7 weeks ago

  • Milestone 5.6 deleted
  • Resolution set to duplicate
  • Status changed from accepted to closed
  • Summary changed from Replace link text. to Replace "This link has expired" error message

Thanks for the patch! Looks like this is already fixed in [49090] / #51351.

Note: See TracTickets for help on using tickets.