Make WordPress Core

Opened 6 years ago

Closed 5 weeks ago

#46080 closed defect (bug) (fixed)

Twenty Seventeen: Pullquote Block - "Write citation…" Text color not working at frontend

Reported by: iamjaydip's profile iamjaydip Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: normal Version: 5.0.3
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing commit
Focuses: css Cc:

Description

When I add Pullquote Block in editor and assign text color from the Color setting it's working properly in backend but it's not working properly in frontend.

Attachments (3)

46080.gif (1.7 MB) - added by iamjaydip 6 years ago.
Pullquote Block: Text color not working at frontend ( Write citation…)
46080.patch (580 bytes) - added by sabernhardt 8 weeks ago.
inherits Pullquote block's text color for blockquote element
SCR-20240812-mbxp.png (35.4 KB) - added by karmatosed 5 weeks ago.

Download all attachments as: .zip

Change History (9)

@iamjaydip
6 years ago

Pullquote Block: Text color not working at frontend ( Write citation…)

#1 @laurelfulford
6 years ago

  • Component changed from Editor to Bundled Theme

Thanks for this report, @iamjaydip! That definitely doesn't look like it's working as expected.

I think this is an issue with Twenty Seventeen's styles specifically, so I'm going to move it to the 'Bundled Themes' component.

#2 @laurelfulford
6 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Pullquote Block: "Write citation…" Text color not working at frontend to Twenty Seventeen: Pullquote Block - "Write citation…" Text color not working at frontend

@sabernhardt
8 weeks ago

inherits Pullquote block's text color for blockquote element

#3 @sabernhardt
8 weeks ago

  • Focuses css added
  • Keywords has-patch added

On the front end, the citation text color has matched the quote text since WordPress 5.9. Since then, block-library styles have also matched the block's default color to the body text instead of the theme's medium gray. At this point, I would consider that the new style for the block.

The iframe editor shows the same colors as the front, but the non-framed editor still shows the gray whether the block uses default or custom colors. I uploaded a patch to override the inlined styles from editor-style.css. If you see top and bottom borders, those come from the block-library/theme.css, and #61591 should correct the sequence by adding editor-blocks.css later.

#4 @karmatosed
5 weeks ago

  • Keywords needs-testing added
  • Owner set to karmatosed
  • Status changed from new to assigned

Thank you @sabernhardt I am going to add testing to this and assign to myself to progress this ticket.

#5 @karmatosed
5 weeks ago

  • Keywords commit added
  • Milestone changed from Future Release to 6.7

In testing, I can confirm this works so going to move this to commit - thank you everyone.

#6 @karmatosed
5 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58886:

Twenty Seventeen: Fixes Pullquote block text color not changing on front.

The Pullquote block text color was not changing on the front. This overrides the inlined styles.

Props iamjaydip, laurelfulford, sabernhardt.
Fixes #46080.

Note: See TracTickets for help on using tickets.