WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#46083 closed defect (bug) (fixed)

Twenty Nineteen: Rogue `÷` character in the print.scss

Reported by: laurelfulford Owned by: SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: trivial Version: 5.0
Component: Bundled Theme Keywords: good-first-bug has-patch commit
Focuses: Cc:

Description

In Twenty Nineteen's print.scss and print.css, there is a ÷ at the end of line 12:

https://core.trac.wordpress.org/browser/tags/5.0.3/src/wp-content/themes/twentynineteen/print.scss#L12

Using a different build set up, this can cause errors when the Sass is compiled:

error print.scss (Line 12: Invalid US-ASCII character "\xC3")

.. though in my experience it doesn't prevent the CSS from being built, and since it's in a comment, doesn't interfere with the theme's styles.

Attachments (1)

46083.patch (895 bytes) - added by mukesh27 3 years ago.
Patch that remove unwanted ÷ character from print.scss and print.css

Download all attachments as: .zip

Change History (6)

#1 @laurelfulford
3 years ago

  • Milestone changed from Awaiting Review to Future Release

@mukesh27
3 years ago

Patch that remove unwanted ÷ character from print.scss and print.css

#2 @karpstrucking
3 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core by sergey. View the logs.


3 years ago

#4 @SergeyBiryukov
3 years ago

  • Keywords commit added
  • Milestone changed from Future Release to 5.2

#5 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 44774:

Twenty Nineteen: Remove stray ÷ character in print.css.

Props mukesh27, laurelfulford.
Fixes #46083.

Note: See TracTickets for help on using tickets.