WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 3 months ago

#46103 new defect (bug)

Missing semicolon after endforeach in wp-includes/media-template.php

Reported by: vishitshah Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 5.0.3
Component: Media Keywords: has-patch
Focuses: Cc:

Description

Missing semicolon after foreach in wp_underscore_audio_template function in this file /wp-includes/media-template.php

Attachments (2)

46103.diff (592 bytes) - added by vishitshah 2 years ago.
46103.2.diff (1.5 KB) - added by mukesh27 2 years ago.
Added missing semicolon in foreach loop.

Download all attachments as: .zip

Change History (4)

@vishitshah
2 years ago

@mukesh27
2 years ago

Added missing semicolon in foreach loop.

#1 @nielslange
2 years ago

@mukesh27 I've tested your patch successfully and also run a project-wide search for other missing semicolons behind <?php endforeach ?> and there are none. Thus, your patch looks good to me!

#2 @sabernhardt
3 months ago

  • Component changed from General to Media
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Missing semicolon after foreach to Missing semicolon after endforeach in wp-includes/media-template.php

46103.2.diff still applies (to the src directory), and it edits all 4 instances of endforeach without the semicolon.

Note: See TracTickets for help on using tickets.