WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 weeks ago

#46103 closed defect (bug) (fixed)

Missing semicolon after endforeach in wp-includes/media-template.php

Reported by: vishitshah Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.0.3
Component: Media Keywords: has-patch
Focuses: coding-standards Cc:

Description

Missing semicolon after foreach in wp_underscore_audio_template function in this file /wp-includes/media-template.php

Attachments (3)

46103.diff (592 bytes) - added by vishitshah 3 years ago.
46103.2.diff (1.5 KB) - added by mukesh27 3 years ago.
Added missing semicolon in foreach loop.
46103.3.diff (1.4 KB) - added by sabernhardt 3 weeks ago.
refresh, from root directory

Download all attachments as: .zip

Change History (7)

@vishitshah
3 years ago

@mukesh27
3 years ago

Added missing semicolon in foreach loop.

#1 @nielslange
3 years ago

@mukesh27 I've tested your patch successfully and also run a project-wide search for other missing semicolons behind <?php endforeach ?> and there are none. Thus, your patch looks good to me!

#2 @sabernhardt
9 months ago

  • Component changed from General to Media
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Missing semicolon after foreach to Missing semicolon after endforeach in wp-includes/media-template.php

46103.2.diff still applies (to the src directory), and it edits all 4 instances of endforeach without the semicolon.

@sabernhardt
3 weeks ago

refresh, from root directory

#3 @sabernhardt
3 weeks ago

  • Focuses coding-standards added
  • Milestone changed from Future Release to 5.9

The changes still are good, and I refreshed the patch to the root directory.

Last edited 3 weeks ago by sabernhardt (previous) (diff)

#4 @SergeyBiryukov
3 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51395:

Coding Standards: Add missing semicolon to endforeach keywords in media templates.

Follow-up to [27411], [27440].

Props vishitshah, mukesh27, nielslange, sabernhardt.
Fixes #46103.

Note: See TracTickets for help on using tickets.