Opened 5 years ago
Last modified 5 years ago
#46108 new enhancement
Twenty Nineteen: Include contributing.txt file with Sass compiler instructions
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | 5.0.3 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
In the GitHub repository, there is a CONTRIBUTING.md
document with instructions for how to compile the Sass for Twenty Nineteen. This file was not migrated over to core.
For those working with the theme (both for direct contributions, and for their own purposes), it'd be helpful to bundle instructions for working with the Sass via the included build tool. The attached patch ports over the "Compiling SCSS" section from the document on GitHub, as a new contributing.txt
file.
https://github.com/WordPress/twentynineteen/blob/master/CONTRIBUTING.md#compling-scss
Attachments (3)
Change History (8)
This ticket was mentioned in Slack in #docs by kjell. View the logs.
5 years ago
#3
@
5 years ago
@nielslange Thanks for fixing that typo. 😄
As for the other note:
Please note that you also need to run
grunt build
orgrunt watch
within/my-computer/local-wordpress-install/
to compile the changes from/my-computer/local-wordpress-install/src
to/my-computer/local-wordpress-install/build
.
This may be confusing for some people, as they may be working from a downloaded copy of the theme. I'd either note that this only applies when working directly with core, or eliminate it (it's more of a general core development convention than a theme workflow note anyway).
@kjellr I made some minor changes, such as changing my-compter to my-computer Apparently, no one noticed this typo yet. 😁
I've also mentioned running
grunt build
orgrunt watch
in the WordPress root folder, to compile the changes from/src
into/build
.