WordPress.org

Make WordPress Core

#46111 closed defect (bug) (fixed)

Admin: Translators comments not in sync in update-core.php

Reported by: tobifjellner Owned by: swissspidy
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description (last modified by afercia)

Several strings in wp-admin/update-core.php for version 5.1 have different number of variables than the corresponding string. Here are a few examples:

https://build.trac.wordpress.org/browser/trunk/wp-admin/update-core.php?marks=83-84#L83

/* translators: 1: URL to WordPress release notes, 1: WordPress version number, 2: Minimum required PHP version number, 3: Current PHP version number */
$message = sprintf( __( 'You cannot update because <a href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher. You are running version %4$s.' ), $version_url, $update->current, $update->php_version, $php_version );

https://build.trac.wordpress.org/browser/trunk/wp-admin/upgrade.php?marks=93-94#L93

/* translators: 1: URL to WordPress release notes, 1: WordPress version number, 2: Minimum required PHP version number, 3: Current PHP version number */
$message = sprintf( __( 'You cannot update because <a href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher. You are running version %4$s.' ), $version_url, $wp_version, $required_php_version, $php_version );

https://build.trac.wordpress.org/browser/trunk/wp-admin/update-core.php?marks=86-87#L86

/* translators: 1: WordPress version number, 2: Minimum required MySQL version number, 3: Current MySQL version number */
$message = sprintf( __( 'You cannot update because <a href="%1$s">WordPress %2$s</a> requires MySQL version %3$s or higher. You are running version %4$s.' ), $version_url, $update->current, $update->mysql_version, $mysql_version );

https://build.trac.wordpress.org/browser/trunk/wp-admin/upgrade.php?marks=96-97#L96

/* translators: 1: WordPress version number, 2: Minimum required MySQL version number, 3: Current MySQL version number */
$message = sprintf( __( 'You cannot update because <a href="%1$s">WordPress %2$s</a> requires MySQL version %3$s or higher. You are running version %4$s.' ), $version_url, $wp_version, $required_mysql_version, $mysql_version );

Change History (3)

#1 @afercia
16 months ago

  • Component changed from Administration to Upgrade/Install
  • Description modified (diff)
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.1
  • Owner set to swissspidy
  • Status changed from new to assigned

Introduced in [44451]. /Cc @swissspidy

#2 @ocean90
16 months ago

In 44700:

Install/Upgrade: After [44451], update translator comments to include the new placeholder.

See #46111.
Fixes #45574.

#3 @ocean90
16 months ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.