WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 months ago

#46122 reviewing enhancement

Code cleanup on $role_links to follow precedent from 46112

Reported by: garrett-eclipse Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch
Focuses: coding-standards Cc:

Description

Hello,

Following from #46112 I applied the same convention to the $role_links and cleaned up the two files;
class-wp-users-list-table.php - https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-users-list-table.php#L197
class-wp-ms-users-list-table.php - https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-ms-users-list-table.php#L142

This continues to standardize the approach and cleans up the code for readability.

Cheers

Attachments (2)

46122.diff (8.1 KB) - added by garrett-eclipse 3 years ago.
Initial patch with code cleanup and standardization
46122.2.diff (5.9 KB) - added by garrett-eclipse 3 years ago.
Initial patch had the patch work from 46112, stripped in this version to isolate the changes

Download all attachments as: .zip

Change History (4)

@garrett-eclipse
3 years ago

Initial patch with code cleanup and standardization

#1 @garrett-eclipse
3 years ago

  • Keywords has-patch added

@garrett-eclipse
3 years ago

Initial patch had the patch work from 46112, stripped in this version to isolate the changes

#2 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.