Make WordPress Core

Opened 5 years ago

Closed 2 years ago

#46122 closed enhancement (maybelater)

Code cleanup on $role_links to follow precedent from 46112

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch close 2nd-opinion
Focuses: coding-standards Cc:

Description

Hello,

Following from #46112 I applied the same convention to the $role_links and cleaned up the two files;
class-wp-users-list-table.php - https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-users-list-table.php#L197
class-wp-ms-users-list-table.php - https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-ms-users-list-table.php#L142

This continues to standardize the approach and cleans up the code for readability.

Cheers

Attachments (2)

46122.diff (8.1 KB) - added by garrett-eclipse 5 years ago.
Initial patch with code cleanup and standardization
46122.2.diff (5.9 KB) - added by garrett-eclipse 5 years ago.
Initial patch had the patch work from 46112, stripped in this version to isolate the changes

Download all attachments as: .zip

Change History (8)

@garrett-eclipse
5 years ago

Initial patch with code cleanup and standardization

#1 @garrett-eclipse
5 years ago

  • Keywords has-patch added

@garrett-eclipse
5 years ago

Initial patch had the patch work from 46112, stripped in this version to isolate the changes

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @hellofromTonya
2 years ago

  • Milestone changed from 5.9 to Future Release

As of yesterday, 5.9 is now in Feature Freeze. Moving this ticket to the next release cycle. But 6.0 is not yet available for selection. Moving it to Future Release. Once 6.0 is available, please feel free to move it into that milestone.

#4 @SergeyBiryukov
2 years ago

  • Milestone changed from Future Release to 6.0

#5 @costdev
2 years ago

  • Keywords close 2nd-opinion added

Both of the current patches, 46122.diff and 46122.2.diff no longer apply cleanly against trunk.

In addition, #42066 seeks to standardise the link generation for the get_views() method in list tables, which may make this ticket obsolete.

Adding close and 2nd-opinion to see what consensus is on closing this ticket in favour of #42066.

#6 @peterwilsoncc
2 years ago

  • Milestone 6.0 deleted
  • Resolution set to maybelater
  • Status changed from reviewing to closed

Per suggestion above, I am closing this in favour of #42066, which has the goal of standardising the get_views method across all list tables.

Note: See TracTickets for help on using tickets.