Make WordPress Core

Opened 3 years ago

Last modified 3 months ago

#46122 reviewing enhancement

Code cleanup on $role_links to follow precedent from 46112

Reported by: garrett-eclipse Owned by: SergeyBiryukov
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch
Focuses: coding-standards Cc:

Description

Hello,

Following from #46112 I applied the same convention to the $role_links and cleaned up the two files;
class-wp-users-list-table.php - https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-users-list-table.php#L197
class-wp-ms-users-list-table.php - https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-ms-users-list-table.php#L142

This continues to standardize the approach and cleans up the code for readability.

Cheers

Attachments (2)

46122.diff (8.1 KB) - added by garrett-eclipse 3 years ago.
Initial patch with code cleanup and standardization
46122.2.diff (5.9 KB) - added by garrett-eclipse 3 years ago.
Initial patch had the patch work from 46112, stripped in this version to isolate the changes

Download all attachments as: .zip

Change History (6)

@garrett-eclipse
3 years ago

Initial patch with code cleanup and standardization

#1 @garrett-eclipse
3 years ago

  • Keywords has-patch added

@garrett-eclipse
3 years ago

Initial patch had the patch work from 46112, stripped in this version to isolate the changes

#2 @SergeyBiryukov
7 months ago

  • Milestone changed from Awaiting Review to 5.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @hellofromTonya
3 months ago

  • Milestone changed from 5.9 to Future Release

As of yesterday, 5.9 is now in Feature Freeze. Moving this ticket to the next release cycle. But 6.0 is not yet available for selection. Moving it to Future Release. Once 6.0 is available, please feel free to move it into that milestone.

#4 @SergeyBiryukov
3 months ago

  • Milestone changed from Future Release to 6.0
Note: See TracTickets for help on using tickets.