Code cleanup on $role_links to follow precedent from 46112

[garrett-eclipse]

Hello,

Following from #46112 I applied the same convention to the $role_links and cleaned up the two files;
class-wp-users-list-table.php - ​https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-users-list-table.php#L197
class-wp-ms-users-list-table.php - ​https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-ms-users-list-table.php#L142

This continues to standardize the approach and cleans up the code for readability.

Cheers

[garrett-eclipse]

Initial patch with code cleanup and standardization

[garrett-eclipse]

Initial patch had the patch work from 46112, stripped in this version to isolate the changes

[hellofromTonya]

As of yesterday, 5.9 is now in Feature Freeze. Moving this ticket to the next release cycle. But 6.0 is not yet available for selection. Moving it to Future Release. Once 6.0 is available, please feel free to move it into that milestone.

[costdev]

Both of the current patches, 46122.diff and 46122.2.diff no longer apply cleanly against trunk.

In addition, #42066 seeks to standardise the link generation for the get_views() method in list tables, which may make this ticket obsolete.

Adding close and 2nd-opinion to see what consensus is on closing this ticket in favour of #42066.

[peterwilsoncc]

Per suggestion above, I am closing this in favour of #42066, which has the goal of standardising the get_views method across all list tables.