WordPress.org

Make WordPress Core

Changes between Initial Version and Version 15 of Ticket #46149


Ignore:
Timestamp:
05/05/2020 10:59:27 AM (18 months ago)
Author:
SergeyBiryukov
Comment:

Replying to SergeyBiryukov:

Note that this still depends on bumping the required PHP version to 7.

Just to clarify, bumping the required version to PHP 7.0 is apparently not enough, as the void return type declarations only appeared in PHP 7.1. So to support PHPUnit 8.x, we'd need PHP 7.1 as the minimum required version.

Updating the ticket description accordingly.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #46149

    • Property Status changed from new to assigned
    • Property Owner set to netweb
    • Property Milestone changed from Awaiting Review to Future Release
    • Property Keywords needs-patch added
    • Property Type changed from defect (bug) to task (blessed)
  • Ticket #46149 – Description

    initial v15  
    2121> `Fatal error: Declaration of WP_UnitTestCase_Base::setUpBeforeClass() must be compatible with PHPUnit\Framework\TestCase::setUpBeforeClass(): void in tests/phpunit/includes/abstract-testcase.php on line 1110`
    2222
    23 We could look into using different signatures for different PHPUnit versions in the same way as in [44701]. However, given the large number of tests extending the `::setUp()` and `::tearDown()` methods, it's probably easier to address this when we [https://make.wordpress.org/core/2018/12/08/updating-the-minimum-php-version/ bump the required PHP version to 7].
     23We could look into using different signatures for different PHPUnit versions in the same way as in [44701]. However, given the large number of tests extending the `::setUp()` and `::tearDown()` methods, it's probably easier to address this when we [https://make.wordpress.org/core/2018/12/08/updating-the-minimum-php-version/ bump the required PHP version to 7.1].