Allow more open document formats

[nbachiyski]

We should allow the upload of more OD formats, not only ODT.

Below is a patch for presentation, spreadsheet, graphics, chart, database and formula.

[JeremyVisser]

+101. Desparately need to allow use of more open formats without hassle.

[Nazgul]

Attached patch won't work. There is an unneeded , after the last array entry.

I'm also not sure about the #. Is that a valid comment indicator in PHP?

[JeremyVisser]

Actually, the comma at the end is okay. Quoted from the PHP manual on ​arrays:

Having a trailing comma after the last defined array entry, while unusual, is a valid syntax.

And, yes, a # is a valid comment indicator, but for consistency with the rest of the WP code, you should change it to .

[nbachiyski]

You are right, about the #: too many perl/python :-)

I usually put а comma after the last element of long arrays, because it is easier to add new lines. You don't have to look where the last element is and add a comma after it. So I stick to it :-)

[Otto42]

I suggest moving wp_check_filetype() into pluggable.php entirely and wrapping it with an if ( !function_exists('wp_check_filetype') ) test entirely.

Why? Well..

While adding new filetypes can be done through a filter, it's somewhat annoying to have to have a plugin or hack the core or mess with your theme just to modify your allowed filetypes.

Also, the current method of having it check by extension is kind of annoying to begin with. It would be nice if we could check by the file content using fileinfo or something (if you have that PECL extension) or looking it up in /etc/mime.types (via mime_content_type() ) or some other way that I cannot describe. Making it pluggable would allow a plugin to replace that function entirely instead of just adding types.

So while I give a +1 to adding more formats, this patch doesn't go far enough, IMO. The entire function should be made pluggable.

[westi]

Replying to Otto42:

I suggest moving wp_check_filetype() into pluggable.php entirely and wrapping it with an if ( !function_exists('wp_check_filetype') ) test entirely.

Why? Well..

While adding new filetypes can be done through a filter, it's somewhat annoying to have to have a plugin or hack the core or mess with your theme just to modify your allowed filetypes.

I don't think this is something to move to pluggable.php. It is quite feasible that multiple plugins may want to extend the list of available mime types when extending WordPress and using pluggable.php means that the first one wins.

Adding new filetypes is easy - you only need to install a plugin that provides a UI for you to do this and you are done - ​http://blog.ftwr.co.uk/wordpress/mime-config/

[Otto42]

Replying to westi:

I don't think this is something to move to pluggable.php. It is quite feasible that multiple plugins may want to extend the list of available mime types when extending WordPress and using pluggable.php means that the first one wins.

Adding new filetypes is easy - you only need to install a plugin that provides a UI for you to do this and you are done - ​http://blog.ftwr.co.uk/wordpress/mime-config/

Adding new filetypes is indeed easy, but changing the way that it detects filetypes in the first place is not. What if I don't want to use the extension only? What if I want to use the "magic" methods to detect the type of file? This should be pluggable so that plugins can change the entire method, not just add new filetypes.

Leave the filter in there as it is, and then plugins can continue to add mime types that way, but if a plugin wants to change the whole thing, then it will be able to do so if the function is pluggable.

[westi]

(In [5929]) Allow upload of all Open Office document types props nbachiyski fixes #4615