Make WordPress Core

Opened 5 years ago

Closed 2 months ago

#46151 closed enhancement (wontfix)

Twenty Nineteen: add support for custom headers

Reported by: puddleglum's profile Puddleglum Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: close
Focuses: Cc:

Description (last modified by swissspidy)

re: PR 133

A standard of static website design is the unifying header whether or not it includes an image (which for style and branding purposes, it MOST often does).

I would hazard that THE MAJORITY of all static WordPress sites use some sort of unifying header with logoing/branding/themeing image. By majority, I mean super super super majority.

The logic in closing PR 133 is therefor nearsighted in the extreme. It's nice to have goals, but not when they leave MOST of those who utilize something standing out in the frigid cold.

FURTHER: The purpose of a Featured Image is to have a Featured Image, not to generate a header. If one wanted to POLITELY hijack the Featured Image one could simply add a 'use for header' checkbox to the Featured Image panel instead of co-opting and changing a long-standing element of WordPress design.

Further, the day after stating that the position is open for discussion, kjellr closes the discussion. 22 days ago he closed PR 243.

allancole reviewed on Nov 5, 2018
Because this theme is primarily focused on Gutenberg, we don’t really want to add too many content-related customizer options. Instead we want to promote the Gutenberg editor as much as possible, so we’re utilizing featured images to achieve the header image behavior.

As always, we’re open to further discussion on this :-)

kjellr commented on Nov 6, 2018
Yes — as per @allancole's notes on focusing on Gutenberg, let's leave this out for now. I'll go ahead and close this.

kjellr closed this on Nov 6, 2018

Re: PR 243

kjellr commented 22 days ago
The PR related to this issue (#133) was closed a few weeks ago, so we could put the customization focus on Gutenberg, not features like custom headers. See @allancole's notes here: #133 (review)

As a result, I'm closing this issue as well. Thank you for your contribution!

kjellr closed this 22 days ago

Change History (3)

#1 @swissspidy
5 years ago

  • Component changed from General to Bundled Theme
  • Description modified (diff)
  • Severity changed from major to normal
  • Summary changed from twentynineteen deliberately ignores majority of wordpress installs (and previous twentyseventeen) using featured image rather than headers. to Twenty Nineteen: add support for custom headers
  • Type changed from feature request to enhancement

#2 @sabernhardt
11 months ago

  • Keywords close added

As part of the proposal to retire default themes, Twenty Nineteen might not have any more enhancements soon. Then changes would only maintain the theme for site owners who have appreciated the theme as it was made.

#3 @karmatosed
2 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I agree with @sabernhardt adding this enhancement right now doesn't fit into the work being done around default themes. The focus should be on bugs first, then seeing what needs to be done with themes going forward. This might mean future enhancements or changes, but for now it means tickets like this should be closed. Thank you everyone for the collaboration on this and we can always reopen.

Note: See TracTickets for help on using tickets.