Opened 7 years ago
Closed 7 years ago
#46164 closed defect (bug) (fixed)
Fix editor.css to properly override all default TinyMCE styles from skin.min.css
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.1 | Priority: | normal |
| Severity: | normal | Version: | 5.0 |
| Component: | TinyMCE | Keywords: | |
| Focuses: | Cc: |
Description
The editor.css stylesheet is meant to override some of the default TinyMCE UI styling. It is loaded last in Classic Editor (mid-page, after we know there is an editor there), but in the Block Editor it is loaded in the head. That exposes few selectors in editor.css that still depend on the loading order.
Attachments (2)
Change History (7)
#2
@
7 years ago
In 46164.diff: make the selectors in editor.css slightly more specific. Fixes styling problems in the Classic Block where editor.css is loaded early.
#3
@
7 years ago
Thinking more about this, currently for the Classic Block we do overrides of the overrides of the default TinyMCE styles. Best would be to fix/refactor editor.css to remove all these "second level" overrides. Opened https://core.trac.wordpress.org/ticket/46173 for that.
This ticket should focus only on fixing known bugs in the Classic Block styling for 5.1. Patch coming up.
There are few (mostly visual) bugs in the Classic Block because of that, see: https://github.com/WordPress/gutenberg/pull/10281.
Will try to patch it before 5.1-RC :)