WordPress.org

Make WordPress Core

Opened 12 months ago

Last modified 3 months ago

#46165 new defect (bug)

Twenty Seventeen's dark theme issue with code blocks

Reported by: ahmadalli Owned by:
Milestone: Awaiting Review Priority: normal
Severity: major Version: 5.0.3
Component: Bundled Theme Keywords: has-patch has-screenshots
Focuses: ui Cc:
PR Number:

Description

there's a section on css containing

body.colors-dark, .colors-dark button, .colors-dark input, .colors-dark select, .colors-dark textarea, .colors-dark h3, .colors-dark h4, .colors-dark h6, .colors-dark label, .colors-dark .entry-title a, .colors-dark.twentyseventeen-front-page .panel-content .recent-posts article, .colors-dark .entry-footer .cat-links a, .colors-dark .entry-footer .tags-links a, .colors-dark .format-quote blockquote, .colors-dark .nav-title, .colors-dark .comment-body {
    color: #eee;
}

the selector also must include

.colors-dark code

Attachments (2)

46165-before-after.png (477.9 KB) - added by metodiew 3 months ago.
Before After image
46165.diff (473 bytes) - added by metodiew 3 months ago.

Download all attachments as: .zip

Change History (4)

#1 @williampatton
10 months ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-screenshots needs-patch added

@metodiew
3 months ago

Before After image

@metodiew
3 months ago

#2 @metodiew
3 months ago

  • Keywords has-patch has-screenshots added; needs-screenshots needs-patch removed

This seems to be a fairly small fix - one line of CSS. You can see the before-after version in the attached image.

Note: See TracTickets for help on using tickets.