WordPress.org

Make WordPress Core

Opened 7 months ago

Last modified 3 months ago

#46170 reopened enhancement

Bundle Google Fonts into the older bundled themes

Reported by: garrett-eclipse Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: 2nd-opinion close
Focuses: performance, privacy Cc:

Description

Similar to #46169 & #36753 this request is to drop the use of Google Fonts for the bundled themes.

Following from a discussion in #core-privacy I'm opening this to move on the Google Fonts issue with Gutenberg.
Discussion - https://wordpress.slack.com/archives/C9695RJBW/p1549043771637800

There's two main concerns;
From a privacy standpoint Google Fonts tracks users collecting PII
From a performance standpoint the assets should be served locally to take advantage of modern font-loading optimization, etc. The cross-domain request slows down the site even with pre-fetching.

From an initial scan this affects all bundled themes starting with Twenty Fourteen, but may just affect ALL as I did a quick search.

Change History (9)

#1 follow-up: @kjellr
7 months ago

From an initial scan this affects all bundled themes starting with Twenty Fourteen, but may just affect ALL as I did a quick search.

Twenty Nineteen's font stack is entirely system fonts, so this should not be a concern there.

#2 @ocean90
7 months ago

  • Component changed from Themes to Bundled Theme
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Changing the fonts is no longer an option for the themes as it would change the theme's initial look and feel. Unlike for the block editor, users can easily change the theme to use one which doesn't use Google Fonts.

As mentioned above, Twenty Nineteen has already dropped Google Fonts. I suspect that future default themes will follow this lead.

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


7 months ago

This ticket was mentioned in Slack in #core-privacy by dejliglama. View the logs.


6 months ago

This ticket was mentioned in Slack in #core-privacy by postphotos. View the logs.


6 months ago

#6 in reply to: ↑ 1 @garrett-eclipse
6 months ago

  • Keywords 2nd-opinion added
  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Summary changed from Use system/native fonts for bundled themes to Bundle Google Fonts into the older bundled themes
  • Type changed from defect (bug) to enhancement

Replying to kjellr:

Twenty Nineteen's font stack is entirely system fonts, so this should not be a concern there.

Replying to ocean90:

As mentioned above, Twenty Nineteen has already dropped Google Fonts. I suspect that future default themes will follow this lead.

Thanks @kjellr & @ocean90 that's great news and happy to hear it's moved in that direction.

Replying to ocean90:

Changing the fonts is no longer an option for the themes as it would change the theme's initial look and feel. Unlike for the block editor, users can easily change the theme to use one which doesn't use Google Fonts.

I'm in complete agreement with you there @ocean90, we shouldn't be changing theme aesthetic on users. As the current option users can switch themes or dequeue the font.

During #core-privacy talks on the subject some ideas were presented with the predominant one being bundle the Google Fonts assets, including license, within the themes to remove the external resource while preserving aesthetic. As such I'm re-opening this for further discussion and changing the title to reflect this.

Aside from the above concept and the original concept of switching to a system font the other idea presented was a Customizer option to disable the fonts.

Last edited 6 months ago by garrett-eclipse (previous) (diff)

#7 @SergeyBiryukov
5 months ago

  • Milestone set to Awaiting Review

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


5 months ago

#9 @westonruter
3 months ago

  • Keywords close added

For the performance concern, Google Fonts now supports font-display natively. For patch which implements this for the core themes, see #47282.

It turns out that Google Fonts serves a wide array of font files depending on the user agent making the request. Different browsers and operating systems get different font files that are tuned for their environments. I learned about this recently myself. If it weren't for this content negotiation then bundling woff2 font files would make sense to me.

Note: See TracTickets for help on using tickets.