WordPress.org

Make WordPress Core

Opened 8 months ago

Last modified 8 months ago

#46213 new defect (bug)

Twenty Nineteen: Remove the incorrect "flexible-header" tag.

Reported by: poena Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:
PR Number:

Description

In style.css, the tag flexible-header is included.

But the requirements for using this tag is that the theme includes
support for a custom header with the flex-height and/or flex-width parameters.

The theme does not have support for a header image.

Ref: https://make.wordpress.org/themes/handbook/review/required/theme-tags/

Attachments (2)

46213.diff (1.8 KB) - added by mukesh27 8 months ago.
Patch.
46213.2.diff (2.7 KB) - added by mukesh27 8 months ago.
Updated patch as suggested by @laurelfulford

Download all attachments as: .zip

Change History (5)

@mukesh27
8 months ago

Patch.

#1 @mukesh27
8 months ago

  • Keywords has-patch added

#2 @laurelfulford
8 months ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to Future Release

Thanks for the report, @poena, and for the patch, @mukesh27!

For the patch, the generated RTL styles also includes a list of the tags -- for completeness, could you also please remove it there? Thanks!

@mukesh27
8 months ago

Updated patch as suggested by @laurelfulford

#3 @mukesh27
8 months ago

  • Keywords needs-refresh removed
Note: See TracTickets for help on using tickets.