Make WordPress Core

Opened 6 years ago

Closed 2 years ago

Last modified 2 years ago

#46213 closed defect (bug) (fixed)

Twenty Nineteen: Remove the incorrect "flexible-header" tag.

Reported by: poena's profile poena Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

In style.css, the tag flexible-header is included.

But the requirements for using this tag is that the theme includes
support for a custom header with the flex-height and/or flex-width parameters.

The theme does not have support for a header image.

Ref: https://make.wordpress.org/themes/handbook/review/required/theme-tags/

Attachments (2)

46213.diff (1.8 KB) - added by mukesh27 6 years ago.
Patch.
46213.2.diff (2.7 KB) - added by mukesh27 6 years ago.
Updated patch as suggested by @laurelfulford

Download all attachments as: .zip

Change History (10)

@mukesh27
6 years ago

Patch.

#1 @mukesh27
6 years ago

  • Keywords has-patch added

#2 @laurelfulford
6 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to Future Release

Thanks for the report, @poena, and for the patch, @mukesh27!

For the patch, the generated RTL styles also includes a list of the tags -- for completeness, could you also please remove it there? Thanks!

@mukesh27
6 years ago

Updated patch as suggested by @laurelfulford

#3 @mukesh27
6 years ago

  • Keywords needs-refresh removed

#4 @poena
2 years ago

  • Keywords commit added
  • Milestone changed from Future Release to 6.2

I can confirm that the patch removes the incorrect tag.

#6 @audrasjb
2 years ago

I added a PR because the tag also need to be removed from the readme file :)
Looks good to me, now.

#7 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 54869:

Twenty Nineteen: Remove the incorrect "flexible-header" tag.

This changeset removes the "flexible-header" tag from Twenty Nineteen, since the requirements for using this tag is that the theme includes support for a custom header with the flex-height and/or flex-width parameters, and Twenty Nineteen does not have support for header image.

Props poena, mukesh27, laurelfulford, audrasjb.
Fixes #46213.

Note: See TracTickets for help on using tickets.