WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 8 months ago

#46239 closed defect (bug) (fixed)

Twenty Nineteen: Remove forced left border from quote block.

Reported by: kjellr Owned by: laurelfulford
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots needs-testing
Focuses: Cc:
PR Number:

Description (last modified by laurelfulford)

An upcoming Gutenberg change will effect behavior of the border on quote blocks:

https://github.com/WordPress/gutenberg/pull/13248

This change will mean:

  • Quote blocks that are left-aligned will have a left border (like they do today).
  • Quote blocks that are centered will have no border.
  • Quote blocks that are right-aligned will have a right border.

Twenty Nineteen's custom styles currently force a left border on quote blocks, regardless of their alignment. This leads to double borders on right-aligned elements when testing that PR:

https://cldup.com/BgZMzFsMzd-2000x2000.png

This PR adjusts Twenty Nineteen's styles to be a little less specific. Instead of supplying the border-style, border-width, and border-color in shorthand, this patch specifies only the border-width, and border-color. This lets quote blocks inherit the border-style (and location) from Gutenberg.

It should have no effect on pullquotes or plain blockquotes as they are today, but will prevent a double border when the aforementioned Gutenberg PR is merged in.

Attachments (3)

46239.patch (4.0 KB) - added by kjellr 9 months ago.
twentynineteen-centre-aligned-frontend.png (88.8 KB) - added by laurelfulford 9 months ago.
Twenty Nineteen - centred quote block, frontend
twentynineteen-centre-aligned-editor.png (99.5 KB) - added by laurelfulford 9 months ago.
Twenty Nineteen - centred quote block, editor

Download all attachments as: .zip

Change History (19)

@kjellr
9 months ago

#1 @laurelfulford
9 months ago

  • Description modified (diff)

#2 @laurelfulford
9 months ago

  • Summary changed from Twenty Nineteen: Remove forced left border from pullquote block. to Twenty Nineteen: Remove forced left border from quote block.

#3 @laurelfulford
9 months ago

  • Keywords has-screenshots needs-testing added
  • Milestone changed from Awaiting Review to 5.1.1

@laurelfulford
9 months ago

Twenty Nineteen - centred quote block, frontend

@laurelfulford
9 months ago

Twenty Nineteen - centred quote block, editor

#4 @laurelfulford
9 months ago

Thanks for tackling this, @kjellr!

Things look good overall -- the only thing I noticed that should be changed is that there's still a slight left padding on the block when the text is centred on both the front-end and in the editor (and for RTL languages, it's on the right). I attached some screenshots so you can see what I mean.

Otherwise, it's looking solid -- and it's nice to get ahead of this update in the theme!

#5 @laurelfulford
9 months ago

Actually, on second glance, I think that this should probably be removed from the block styles, and not the theme styles, correct?

#6 @laurelfulford
9 months ago

Filed a ticket for the padding here, and included a PR: https://github.com/WordPress/gutenberg/issues/13845

Going to see if I can get confirmation that that should be fixed there, rather than in the theme itself!

#7 @kjellr
9 months ago

Good catch! Yes, that padding isn't added via Twenty Nineteen, it's from the default Gutenberg styles. Thanks for the Gutenberg PR too! 🎉

If that's the only remaining item on this ticket, we should be good to go.

#8 @laurelfulford
9 months ago

  • Owner set to laurelfulford
  • Resolution set to fixed
  • Status changed from new to closed

In 44739:

Twenty Nineteen: Update the quote block styles.

Update the theme's quote block border styles, so they will work better with the updated styles for the quote block, coming in Gutenberg 5.2.

Props @kjellr.
Fixes #46239.

#9 @laurelfulford
9 months ago

Great! Thanks for your work here, @kjellr!

#10 @pento
9 months ago

@laurelfulford: Was this intended to go in 5.1 or 5.1.1? 5.1 hasn't been branched yet, so [44739] was possibly committed a little early. 🙂

#11 @laurelfulford
9 months ago

@pento Ah shoot, it was meant to go into 5.1.1! Please let me know if I should revert, or some other course of action to fix!

#12 @peterwilsoncc
9 months ago

In 44743:

Twenty Nineteen: Revert [44739] from the 5.1 branch.

Reverts block quote style changes intended for a later release.

See #46239.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


9 months ago

#14 follow-up: @laurelfulford
9 months ago

  • Milestone changed from 5.1.1 to 5.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening, and assigning to 5.2, since it is, right now, the only theme update lined up for 5.1.1.

#15 in reply to: ↑ 14 @SergeyBiryukov
9 months ago

Replying to laurelfulford:

Reopening, and assigning to 5.2, since it is, right now, the only theme update lined up for 5.1.1.

I think it can be closed as fixed for 5.2 in [44739]. Is there anything else left here?

#16 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.