Twenty Nineteen: Remove forced left border from quote block.

[kjellr]

An upcoming Gutenberg change will effect behavior of the border on quote blocks:

​https://github.com/WordPress/gutenberg/pull/13248

This change will mean:

• Quote blocks that are left-aligned will have a left border (like they do today).
• Quote blocks that are centered will have no border.
• Quote blocks that are right-aligned will have a right border.

Twenty Nineteen's custom styles currently force a left border on quote blocks, regardless of their alignment. This leads to double borders on right-aligned elements when testing that PR:

This PR adjusts Twenty Nineteen's styles to be a little less specific. Instead of supplying the border-style, border-width, and border-color in shorthand, this patch specifies only the border-width, and border-color. This lets quote blocks inherit the border-style (and location) from Gutenberg.

It should have no effect on pullquotes or plain blockquotes as they are today, but will prevent a double border when the aforementioned Gutenberg PR is merged in.

[laurelfulford]

Twenty Nineteen - centred quote block, frontend

[laurelfulford]

Twenty Nineteen - centred quote block, editor

[laurelfulford]

Thanks for tackling this, @kjellr!

Things look good overall -- the only thing I noticed that should be changed is that there's still a slight left padding on the block when the text is centred on both the front-end and in the editor (and for RTL languages, it's on the right). I attached some screenshots so you can see what I mean.

Otherwise, it's looking solid -- and it's nice to get ahead of this update in the theme!

[laurelfulford]

Actually, on second glance, I think that this should probably be removed from the block styles, and not the theme styles, correct?

[laurelfulford]

Filed a ticket for the padding here, and included a PR: ​https://github.com/WordPress/gutenberg/issues/13845

Going to see if I can get confirmation that that should be fixed there, rather than in the theme itself!

[kjellr]

Good catch! Yes, that padding isn't added via Twenty Nineteen, it's from the default Gutenberg styles. Thanks for the Gutenberg PR too! 🎉

If that's the only remaining item on this ticket, we should be good to go.

[laurelfulford]

In 44739:

Twenty Nineteen: Update the quote block styles.

Update the theme's quote block border styles, so they will work better with the updated styles for the quote block, coming in Gutenberg 5.2.

Props @kjellr.
Fixes #46239.

[laurelfulford]

Great! Thanks for your work here, @kjellr!

[pento]

@laurelfulford: Was this intended to go in 5.1 or 5.1.1? 5.1 hasn't been branched yet, so [44739] was possibly committed a little early. 🙂

[laurelfulford]

@pento Ah shoot, it was meant to go into 5.1.1! Please let me know if I should revert, or some other course of action to fix!

[peterwilsoncc]

In 44743:

Twenty Nineteen: Revert [44739] from the 5.1 branch.

Reverts block quote style changes intended for a later release.

See #46239.

[laurelfulford]

Reopening, and assigning to 5.2, since it is, right now, the only theme update lined up for 5.1.1.

[SergeyBiryukov]

Replying to laurelfulford:

Reopening, and assigning to 5.2, since it is, right now, the only theme update lined up for 5.1.1.

I think it can be closed as fixed for 5.2 in [44739]. Is there anything else left here?