WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46239


Ignore:
Timestamp:
02/12/2019 08:02:38 PM (6 years ago)
Author:
laurelfulford
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #46239 – Description

    initial v1  
    1 An upcoming Gutenberg change will effect behavior of the border on pull quote blocks:
     1An upcoming Gutenberg change will effect behavior of the border on quote blocks:
    22
    33https://github.com/WordPress/gutenberg/pull/13248
    … …  
    55This change will mean:
    66
    7 - Pullquote blocks that are left-aligned will have a left border (like they do today).
    8 - Pullquote blocks that are centered will have no border.
    9 - Pullquote blocks that are right-aligned will have a right border.
     7- Quote blocks that are left-aligned will have a left border (like they do today).
     8- Quote blocks that are centered will have no border.
     9- Quote blocks that are right-aligned will have a right border.
    1010
    11 Twenty Nineteen's custom styles currently force a left border on pullquote blocks, regardless of their alignment. This leads to double borders on right-aligned elements when testing that PR:
     11Twenty Nineteen's custom styles currently force a left border on quote blocks, regardless of their alignment. This leads to double borders on right-aligned elements when testing that PR:
    1212
    1313[[Image(https://cldup.com/BgZMzFsMzd-2000x2000.png)]]
    1414
    15 This PR adjusts Twenty Nineteen's styles to be a little less specific. Instead of supplying the `border-style`, `border-width`, and `border-color` in shorthand, this patch specifies only the `border-width`, and `border-color`. This lets pullquote blocks inherit the `border-style` (and location) from Gutenberg.
     15This PR adjusts Twenty Nineteen's styles to be a little less specific. Instead of supplying the `border-style`, `border-width`, and `border-color` in shorthand, this patch specifies only the `border-width`, and `border-color`. This lets quote blocks inherit the `border-style` (and location) from Gutenberg.
    1616
    1717It should have no effect on pullquotes or plain blockquotes as they are today, but will prevent a double border when the aforementioned Gutenberg PR is merged in.