WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 10 of Ticket #46260


Ignore:
Timestamp:
02/18/2019 11:57:52 AM (6 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #46260

    • Property Status changed from new to reopened
    • Property Owner set to peterwilsoncc
    • Property Milestone changed from Awaiting Review to 5.1
    • Property Keywords has-patch commit fixed-major added

  • Ticket #46260 – Description

    initial v10  
    55In WP 5.0 and before, the comment reply links were hardcoded to the onclick event, seen here: https://github.com/WordPress/WordPress/commit/f617a2d6d932e658449cef1b7864fb77080ecd09#diff-3db08a6b98155b349c93a220bc903dceL1670
    66
    7 But in 5.1+ (since https://core.trac.wordpress.org/ticket/31590), `comment-reply.js` initializes by binding these links to the event handler. The problem is though, these links won't exist yet when the script is first loaded since they come in later via ajax.
     7But in 5.1+ (since #31590), `comment-reply.js` initializes by binding these links to the event handler. The problem is though, these links won't exist yet when the script is first loaded since they come in later via ajax.
    88
    99== Replicating / Solutions