#46272 closed defect (bug) (fixed)
Add 'custom-logo' to feature list API
| Reported by: | DannyCooper | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | WordPress.org |
| Component: | Themes | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
'custom-logo' is a valid theme tag, but it doesn't appear in the API - https://api.wordpress.org/themes/info/1.1/?action=feature_list
One consequence of this is that the "Theme Sniffer" reports it as an invalid tag - https://github.com/WPTRT/theme-sniffer
Change History (12)
This ticket was mentioned in Slack in #meta by dingo_d. View the logs.
8 years ago
This ticket was mentioned in Slack in #themereview by dannycooper. View the logs.
8 years ago
#4
@
8 years ago
API Commit: https://meta.trac.wordpress.org/changeset/8273
Before the wide-blocks (3 themes) and block-styles (4 themes) tags can be returned for WordPress, Core needs to be updated to add the translation/label here:
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/theme.php#L250
I've set the API to return them for WordPress 5.2+, assuming that the translations/labels can be added in trunk. If it gets backported into 5.1.x we can update the API as such, but I'm hopeful there'll be more than a handful of themes in those tags before Core supports it, as it's not a nice user-experience landing on a nearly-empty tag.
custom-logo is now being returned for WordPress >= 4.6.
And requesting https://api.wordpress.org/themes/info/1.1/?action=feature_list (or preferably, https://api.wordpress.org/themes/info/1.2/?action=feature_list) will return those new tags regardless of core support.
This ticket was mentioned in Slack in #meta by dingo_d. View the logs.
7 years ago
#7
@
7 years ago
- Resolution → worksforme
- Status new → closed
This has been implemented, right? So the ticket can be closed. If we'll need new ones, we'll open a new ticket :)
If I missed something feel free to reopen it.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Two more valid tags that aren't present: 'block-styles' and 'wide-blocks'.