WordPress.org

Make WordPress Core

Opened 21 months ago

Closed 15 months ago

Last modified 6 months ago

#46272 closed defect (bug) (fixed)

Add 'custom-logo' to feature list API

Reported by: DannyCooper Owned by:
Milestone: WordPress.org Priority: normal
Severity: normal Version:
Component: Themes Keywords:
Focuses: Cc:

Description

'custom-logo' is a valid theme tag, but it doesn't appear in the API - https://api.wordpress.org/themes/info/1.1/?action=feature_list

One consequence of this is that the "Theme Sniffer" reports it as an invalid tag - https://github.com/WPTRT/theme-sniffer

Change History (12)

#1 @DannyCooper
21 months ago

Two more valid tags that aren't present: 'block-styles' and 'wide-blocks'.

Last edited 21 months ago by DannyCooper (previous) (diff)

This ticket was mentioned in Slack in #meta by dingo_d. View the logs.


21 months ago

This ticket was mentioned in Slack in #themereview by dannycooper. View the logs.


21 months ago

#4 @dd32
21 months ago

API Commit: https://meta.trac.wordpress.org/changeset/8273

Before the wide-blocks (3 themes) and block-styles (4 themes) tags can be returned for WordPress, Core needs to be updated to add the translation/label here:
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/theme.php#L250

I've set the API to return them for WordPress 5.2+, assuming that the translations/labels can be added in trunk. If it gets backported into 5.1.x we can update the API as such, but I'm hopeful there'll be more than a handful of themes in those tags before Core supports it, as it's not a nice user-experience landing on a nearly-empty tag.

custom-logo is now being returned for WordPress >= 4.6.

And requesting https://api.wordpress.org/themes/info/1.1/?action=feature_list (or preferably, https://api.wordpress.org/themes/info/1.2/?action=feature_list) will return those new tags regardless of core support.

#5 @DannyCooper
21 months ago

Thanks @dd32!

This ticket was mentioned in Slack in #meta by dingo_d. View the logs.


15 months ago

#7 @dingo_d
15 months ago

  • Resolution set to worksforme
  • Status changed from new to closed

This has been implemented, right? So the ticket can be closed. If we'll need new ones, we'll open a new ticket :)

If I missed something feel free to reopen it.

#8 @SergeyBiryukov
15 months ago

  • Component changed from General to Themes
  • Milestone changed from Awaiting Review to WordPress.org
  • Resolution changed from worksforme to fixed

#9 @SergeyBiryukov
6 months ago

In 47790:

Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features.

These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now.

Follow-up to [meta8273].

See #46272.

#10 @SergeyBiryukov
6 months ago

In 47791:

Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features.

These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now.

Follow-up to [meta8273].

Merges [47790] to the 5.4 branch.
See #46272.

#11 @SergeyBiryukov
6 months ago

In 47792:

Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features.

These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now.

Follow-up to [meta8273].

Merges [47790] to the 5.3 branch.
See #46272.

#12 @SergeyBiryukov
6 months ago

In 47793:

Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features.

These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now.

Follow-up to [meta8273].

Merges [47790] to the 5.2 branch.
See #46272.

Note: See TracTickets for help on using tickets.