Context Navigation

← Previous Ticket
Next Ticket →

#46289 closed defect (bug) (fixed)

RTL Bug: wrong navigation arrows in media modal

Reported by:	ramiy	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.2.2
Component:	Media	Version:
Severity:	normal	Keywords:	has-screenshots fixed-major
Cc:		Focuses:	ui, rtl, administration

Description

This bug exists in several version of WordPress.

When displaying an image in the media library, the media-modal has two navigation arrows that are displayed in wrong directions in RTL languages (I use Hebrew).

See the attached screenshot.

Attachments (1)

WordPress-Media-Item-Display.png (139.7 KB ) - added by ramiy 7 years ago.

Download all attachments as: .zip

Change History (13)

@ramiy
7 years ago

Attachment WordPress-Media-Item-Display.png added

#1 @ramiy
7 years ago

Keywords needs-patch has-screenshots added

#2 @pento
7 years ago

Version trunk

#3 @joemcgill
7 years ago

Milestone Awaiting Review → Future Release

Thanks for the report @ramiy. I imagine this is quite a confusing/annoying bug. Let's fix it!

#4 @ramiy
7 years ago

@joemcgill Can you please change the Milestone to 5.3?

This ticket was mentioned in Slack in #core by desrosj. View the logs.

7 years ago

#6 @SergeyBiryukov
7 years ago

Milestone Future Release → 5.2.2

This was previously fixed in [29264], but since [31579] we use a build task to replace dashicons for RTL.

[29264] should be reverted.

#7 @SergeyBiryukov
7 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 45495:

Media: Restore correct arrow direction in RTL in Attachment Details modal.

Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Fixes #46289.

#8 @SergeyBiryukov
7 years ago

Keywords fixed-major added; needs-patch removed
Resolution fixed
Status closed → reopened

Reopening for 5.2.2 consideration.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.

7 years ago

#10 @audrasjb
7 years ago

As per today's bug scrub, let's backport this ticket to 5.2.2.

#11 @audrasjb
7 years ago

Hi @SergeyBiryukov do you think we can have a backport for this ticket today so we can ship that on 5.2.2 RC1?
Thank you! The RC processing is going to start at 19:00 UTC.

#12 @SergeyBiryukov
7 years ago

Resolution → fixed
Status reopened → closed

In 45511:

Media: Restore correct arrow direction in RTL in Attachment Details modal.

Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Merges [45495] to the 5.2 branch.
Fixes #46289.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#46289 closed defect (bug) (fixed)

RTL Bug: wrong navigation arrows in media modal

Description

Attachments (1)

Change History (13)

@ramiy 7 years ago

#1 @ramiy 7 years ago

#2 @pento 7 years ago

#3 @joemcgill 7 years ago

#4 @ramiy 7 years ago

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs. 7 years ago

#6 @SergeyBiryukov 7 years ago

#7 @SergeyBiryukov 7 years ago

#8 @SergeyBiryukov 7 years ago

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs. 7 years ago

#10 @audrasjb 7 years ago

#11 @audrasjb 7 years ago

#12 @SergeyBiryukov 7 years ago