WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#46289 closed defect (bug) (fixed)

RTL Bug: wrong navigation arrows in media modal

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 5.2.2 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-screenshots fixed-major
Focuses: ui, rtl, administration Cc:

Description

This bug exists in several version of WordPress.

When displaying an image in the media library, the media-modal has two navigation arrows that are displayed in wrong directions in RTL languages (I use Hebrew).

See the attached screenshot.

Attachments (1)

WordPress-Media-Item-Display.png​ (139.7 KB) - added by ramiy 3 years ago.

Download all attachments as: .zip

Change History (13)

@ramiy
3 years ago

#1 @ramiy
3 years ago

  • Keywords needs-patch has-screenshots added

#2 @pento
3 years ago

  • Version trunk deleted

#3 @joemcgill
3 years ago

  • Milestone changed from Awaiting Review to Future Release

Thanks for the report @ramiy. I imagine this is quite a confusing/annoying bug. Let's fix it!

#4 @ramiy
3 years ago

@joemcgill Can you please change the Milestone to 5.3?

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
3 years ago

#6 @SergeyBiryukov
3 years ago

  • Milestone changed from Future Release to 5.2.2

This was previously fixed in [29264], but since [31579] we use a build task to replace dashicons for RTL.

[29264] should be reverted.

#7 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45495:

Media: Restore correct arrow direction in RTL in Attachment Details modal.

Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Fixes #46289.

#8 @SergeyBiryukov
3 years ago

  • Keywords fixed-major added; needs-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.2.2 consideration.

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
3 years ago

#10 @audrasjb
3 years ago

As per today's bug scrub, let's backport this ticket to 5.2.2.

#11 @audrasjb
3 years ago

Hi @SergeyBiryukov do you think we can have a backport for this ticket today so we can ship that on 5.2.2 RC1?
Thank you! The RC processing is going to start at 19:00 UTC.

#12 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45511:

Media: Restore correct arrow direction in RTL in Attachment Details modal.

Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Merges [45495] to the 5.2 branch.
Fixes #46289.

Note: See TracTickets for help on using tickets.