WordPress.org

Make WordPress Core

#46320 closed enhancement (fixed)

Replace http with https in the link placeholder widget image

Reported by: Chaton666 Owned by: audrasjb
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Widgets Keywords: has-patch has-screenshots commit
Focuses: administration Cc:

Description

Replace http with https in the link placeholder widget image when choosing "link to" : "custom URL" setting.

Attachments (7)

46320.diff (1.5 KB) - added by Chaton666 20 months ago.
before-preview.PNG (21.9 KB) - added by Chaton666 20 months ago.
before-edit.PNG (29.9 KB) - added by Chaton666 20 months ago.
after-preview.PNG (21.9 KB) - added by Chaton666 20 months ago.
after-editr.PNG (29.5 KB) - added by Chaton666 20 months ago.
46320.2.diff (896 bytes) - added by mukesh27 20 months ago.
Updated patch.
46320.3.diff (912 bytes) - added by audrasjb 15 months ago.
Patch refreshed

Download all attachments as: .zip

Change History (18)

@Chaton666
20 months ago

#2 @audrasjb
20 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Hi @Chaton666 and welcome to WordPress Trac

Thanks for the patch and for the screenshots.

The existing placeholder can make think that the user must use http. We should encourage the use of https.
Also, the block editor uses https for its placeholders. Let's add some consistency.

The patch looks good at a glance, but we should consider to not use a value attribute but a placeholder. ( Related: #46312 see @afercia 's comment)

Related: #46312

#3 @johnbillion
20 months ago

  • Keywords close added
  • Version 5.1 deleted

On the surface this might look like a good idea but I don't believe this encourages users to use HTTPS. A site either uses HTTPS or it doesn't.

Changing the default scheme will lead to broken links when the site is not available over HTTPS but the user doesn't notice the default https scheme.

#4 @audrasjb
20 months ago

Hi @johnbillion

In 46320.diff there is two changes:

  • the change on src/js/media/views/settings/attachment-display.js is not a good idea. But it's not a good idea to use the value attribute too. We should only use the placeholder attribute. Also, this change is not strictly related to the ticket. It should be a specific ticket assigned to #core-media team. I think we need a new patch without this change.
  • the change on src/wp-includes/widgets/class-wp-widget-media-image.php looks nice on my side. This is only a placeholder. We should encourage the use of https instead of http.

#5 @audrasjb
20 months ago

  • Keywords close removed

#6 @audrasjb
20 months ago

  • Keywords 2nd-opinion added

@mukesh27
20 months ago

Updated patch.

#7 @audrasjb
20 months ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Awaiting Review to 5.2
  • Status changed from reviewing to accepted

Related: #46312

The last patch looks good to me. Let's handle this ticket along with #46312 which have been marked commit during today's new contributor meeting.

#8 @audrasjb
20 months ago

  • Keywords commit added

46320.2.diff is good to land in 5.2.
Adding commit keyword.

#9 @SergeyBiryukov
19 months ago

  • Milestone changed from 5.2 to 5.3

Moving to early 5.3 along with #46312.

#10 @audrasjb
15 months ago

  • Keywords needs-refresh added; commit removed

The patch doesn't applies cleanly. Adding needs-refresh keyword.

@audrasjb
15 months ago

Patch refreshed

#11 @audrasjb
15 months ago

  • Keywords commit added; needs-refresh removed

In 46320.3.diff I refreshed the current patch. I think we are good to go.

#12 @whyisjake
15 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 45777:

Widgets: Replace http with https in the link placeholder widget image

The existing placeholder can make the user think that they must use http. We should encourage the use of https.
Also, the block editor uses https for its placeholders. Let's add some consistency.

Props Chaton666, audrasjb, mukesh27.
Fixes #46320.

Note: See TracTickets for help on using tickets.