Replace http with https in the link placeholder widget image

[Chaton666]

Replace http with https in the link placeholder widget image when choosing "link to" : "custom URL" setting.

[audrasjb]

Hi @Chaton666 and welcome to WordPress Trac

Thanks for the patch and for the screenshots.

The existing placeholder can make think that the user must use http. We should encourage the use of https.
Also, the block editor uses https for its placeholders. Let's add some consistency.

The patch looks good at a glance, but we should consider to not use a value attribute but a placeholder. ( Related: #46312 see @afercia 's comment)

Related: #46312

[johnbillion]

On the surface this might look like a good idea but I don't believe this encourages users to use HTTPS. A site either uses HTTPS or it doesn't.

Changing the default scheme will lead to broken links when the site is not available over HTTPS but the user doesn't notice the default https scheme.

[audrasjb]

Hi @johnbillion

In 46320.diff there is two changes:

• the change on src/js/media/views/settings/attachment-display.js is not a good idea. But it's not a good idea to use the value attribute too. We should only use the placeholder attribute. Also, this change is not strictly related to the ticket. It should be a specific ticket assigned to #core-media team. I think we need a new patch without this change.
• the change on src/wp-includes/widgets/class-wp-widget-media-image.php looks nice on my side. This is only a placeholder. We should encourage the use of https instead of http.

[mukesh27]

Updated patch.

[audrasjb]

Related: #46312

The last patch looks good to me. Let's handle this ticket along with #46312 which have been marked commit during today's new contributor meeting.

[audrasjb]

46320.2.diff is good to land in 5.2.
Adding commit keyword.

[SergeyBiryukov]

Moving to early 5.3 along with #46312.

[audrasjb]

The patch doesn't applies cleanly. Adding needs-refresh keyword.

[audrasjb]

Patch refreshed

[audrasjb]

In 46320.3.diff I refreshed the current patch. I think we are good to go.

[whyisjake]

In 45777:

Widgets: Replace http with https in the link placeholder widget image

The existing placeholder can make the user think that they must use http. We should encourage the use of https.
Also, the block editor uses https for its placeholders. Let's add some consistency.

Props Chaton666, audrasjb, mukesh27.
Fixes #46320.