Make WordPress Core

Opened 5 months ago

Last modified 4 months ago

#46320 accepted enhancement

Replace http with https in the link placeholder widget image

Reported by: Chaton666 Owned by: audrasjb
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Widgets Keywords: has-patch has-screenshots commit
Focuses: administration Cc:


Replace http with https in the link placeholder widget image when choosing "link to" : "custom URL" setting.

Attachments (6)

46320.diff (1.5 KB) - added by Chaton666 5 months ago.
before-preview.PNG (21.9 KB) - added by Chaton666 5 months ago.
before-edit.PNG (29.9 KB) - added by Chaton666 5 months ago.
after-preview.PNG (21.9 KB) - added by Chaton666 5 months ago.
after-editr.PNG (29.5 KB) - added by Chaton666 5 months ago.
46320.2.diff (896 bytes) - added by mukesh27 5 months ago.
Updated patch.

Download all attachments as: .zip

Change History (14)

5 months ago

#2 @audrasjb
5 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Hi @Chaton666 and welcome to WordPress Trac

Thanks for the patch and for the screenshots.

The existing placeholder can make think that the user must use http. We should encourage the use of https.
Also, the block editor uses https for its placeholders. Let's add some consistency.

The patch looks good at a glance, but we should consider to not use a value attribute but a placeholder. ( Related: #46312 see @afercia 's comment)

Related: #46312

#3 @johnbillion
5 months ago

  • Keywords close added
  • Version 5.1 deleted

On the surface this might look like a good idea but I don't believe this encourages users to use HTTPS. A site either uses HTTPS or it doesn't.

Changing the default scheme will lead to broken links when the site is not available over HTTPS but the user doesn't notice the default https scheme.

#4 @audrasjb
5 months ago

Hi @johnbillion

In 46320.diff there is two changes:

  • the change on src/js/media/views/settings/attachment-display.js is not a good idea. But it's not a good idea to use the value attribute too. We should only use the placeholder attribute. Also, this change is not strictly related to the ticket. It should be a specific ticket assigned to #core-media team. I think we need a new patch without this change.
  • the change on src/wp-includes/widgets/class-wp-widget-media-image.php looks nice on my side. This is only a placeholder. We should encourage the use of https instead of http.

#5 @audrasjb
5 months ago

  • Keywords close removed

#6 @audrasjb
5 months ago

  • Keywords 2nd-opinion added

5 months ago

Updated patch.

#7 @audrasjb
4 months ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Awaiting Review to 5.2
  • Status changed from reviewing to accepted

Related: #46312

The last patch looks good to me. Let's handle this ticket along with #46312 which have been marked commit during today's new contributor meeting.

#8 @audrasjb
4 months ago

  • Keywords commit added

46320.2.diff is good to land in 5.2.
Adding commit keyword.

#9 @SergeyBiryukov
4 months ago

  • Milestone changed from 5.2 to 5.3

Moving to early 5.3 along with #46312.

Note: See TracTickets for help on using tickets.