WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 4 months ago

#46326 new enhancement

Please Display the PHP Version Number when it's outdated.

Reported by: christinahills Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.1
Component: Site Health Keywords: ux-feedback has-patch has-screenshots 2nd-opinion
Focuses: Cc:

Description

Hi!

I am super excited about the new 5.1 and how it lets us know when our PHP
is outdated.

however, it would be really nice if it would display the version number we are running when it displays that it's out of date.

I had to install the plugin "Display PHP Version" to see the version #

It does not seem like it would be too hard to add that to core, since you are already displaying that it's out of date.

See my example in this pic.
https://websitecreationworkshop.com/wp-content/uploads/2019/02/displayphpplease.png

thanks so much,
Christina Hills

Attachments (4)

displayphpplease.png (37.8 KB) - added by christinahills 3 years ago.
pic of the issue I am talking about with the PHP version not being shown
46326.diff (1.2 KB) - added by mukesh27 3 years ago.
Patch to add PHP version info in PHP Update Required dashboard widget.
after-applying-patch.png (33.7 KB) - added by mukesh27 3 years ago.
46326.2.diff (942 bytes) - added by bhargavmehta 3 years ago.
Modified for translations

Download all attachments as: .zip

Change History (14)

@christinahills
3 years ago

pic of the issue I am talking about with the PHP version not being shown

@mukesh27
3 years ago

Patch to add PHP version info in PHP Update Required dashboard widget.

#1 @mukesh27
3 years ago

  • Keywords has-patch has-screenshots 2nd-opinion added

Hi @christinahills, Welcome to WordPress Trac! Thank you for your ticket.

Good cache. After apply above patch you get current PHP version in PHP Update Required dashboard widget.

#2 @christinahills
3 years ago

@mukesh27 Thank you so much!

Looking forward to having all my clients/students see this php version displayed in the next update of WordPress :) I will let them know.

Thanks for responding to this so quickly

-Christina

Last edited 3 years ago by christinahills (previous) (diff)

#3 @bhargavmehta
3 years ago

Hello,

I have updated the code to add translations of the string using sprintf.

Added patch for the same.

Thank you

@bhargavmehta
3 years ago

Modified for translations

This ticket was mentioned in Slack in #core by bhargavmehta. View the logs.


2 years ago

#5 @garrett-eclipse
2 years ago

  • Component changed from General to Site Health

Thanks @bhargavmehta the patch looks good, I've moved to Site Health component for further review.

#6 @garrett-eclipse
2 years ago

Related - #47651

Also adding needs-copy-review to look at how the proposed strings read, they are;
'WordPress has detected that your site is running on an insecure version of PHP %s.'
'WordPress has detected that your site is running on an outdated version of PHP %s.'
Note: %s refers to the version number.

#7 @afragen
2 years ago

I wonder whether putting the current running version into the Site Health warning with a link in the dashboard widget to Site Health would be more efficient. Yes, I realize this wouldn't backport.

What do you think @clorith

#9 @Clorith
2 years ago

I did just leave a note on the related ticket at #48390 (sorry for not spotting this ticket sooner) about the inclusion of version strings in the servehappy notice (which is what we call the dashboard widget notifying users of outdated PHP versions).

I'll cover it here as well, for completeness, and to get input whee possible;

I'm personally not a fan of numbers in user-facing strings, as they make text appear more technical than they need to be, especially when the numbers don't mean anything to the end user. That being said, I'm always open to discussions about it, so in an ideal world, what does this look like to you, how would you frame it so that it's accessible to users without seeming like too technical of a task?

#10 @zodiac1978
4 months ago

After #48390 is closed as Wontfix, I think this can be closed too. @Clorith What do you think?

Note: See TracTickets for help on using tickets.