WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46367, comment 2


Ignore:
Timestamp:
05/04/2019 06:02:23 PM (5 years ago)
Author:
garrett-eclipse
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #46367, comment 2

    initial v1  
    33Reviewing the setup WP has, the create menu redirects the user to `nav-menus.php?action=edit&menu=0` so taking the user back to `nav-menus.php` seems like the most appropriate course here.
    44
    5 I setup an initial patch for this in [https://core.trac.wordpress.org/attachment/ticket/46367/46367.diff 46367.diff] (and minor tweak in [https://core.trac.wordpress.org/attachment/ticket/46367/46367.2.diff 46367.2.diff] to cleanup the conditional), which introduces the menu-cancel action link. To give it the same red as the menu-delete action I've added the selector to the common.css menu where menu-cancel is setup. I'm not sure if we want to give it an alternate colour but felt it made sense and should never appear alongside the menu-delete action.
     5I setup an initial patch for this in [https://core.trac.wordpress.org/attachment/ticket/46367/46367.diff 46367.diff] (and minor tweak in [https://core.trac.wordpress.org/attachment/ticket/46367/46367.2.diff 46367.2.diff] to cleanup the conditional), which introduces the menu-cancel action link. To give it the same red as the menu-delete action I've added the selector to the common.css file where menu-cancel is setup. I'm not sure if we want to give it an alternate colour but felt it made sense and should never appear alongside the menu-delete action.
    66
    77Give it a shot and let me know if you have any issues.