WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#46369 closed defect (bug) (fixed)

Apply esc_url to edit and view privacy policy page urls & update translator comments

Reported by: garrett-eclipse Owned by: SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch
Focuses: coding-standards Cc:
PR Number:

Description

Splitting off from #44761 this ticket is to apply coding standards, translation improvement and escape the urls in the 'Edit or view your Privacy Policy page content.' string.

Patch 44761.2.diff started by @birgire here should get props;
https://core.trac.wordpress.org/attachment/ticket/44761/44761.2.diff

But will also want to account for the comment here;

Attempting to apply the patch currently fails for trunk. Along with a refresh I'm wondering if we can move the translator comments within the multiline printf statements.
Example from Coding Standards - https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#multiline-function-calls
I also feel the two instances of this translator comment could be made more explicit by indicating it's for the Privacy Policy page.
/* translators: 1: URL to edit page, 2: URL to preview page */
I'm thinking;
/* translators: 1: URL to edit Privacy Policy page, 2: URL to preview Privacy Policy page */

Reference - https://core.trac.wordpress.org/ticket/44761?replyto=8#comment:7

Cheers

Attachments (1)

46369.diff (1.2 KB) - added by garrett-eclipse 9 months ago.
Updated patch from original by @birgire to take into account translator comment being moved and updated.

Download all attachments as: .zip

Change History (5)

@garrett-eclipse
9 months ago

Updated patch from original by @birgire to take into account translator comment being moved and updated.

#1 @garrett-eclipse
9 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
9 months ago

  • Milestone changed from Awaiting Review to 5.2

#3 @SergeyBiryukov
9 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 44778:

Privacy: Improve translator comments for Privacy Policy page links in Privacy Settings; escape URLs.

Props birgire, garrett-eclipse.
Fixes #46369.

#4 @garrett-eclipse
9 months ago

Thanks @SergeyBiryukov

Note: See TracTickets for help on using tickets.