WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 3 months ago

#46386 closed enhancement (fixed)

Credits: Make WordPress.org URL translatable

Reported by: mukesh27 Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch good-first-bug
Focuses: Cc:
PR Number:

Description

Need to add tranlation for link https://wordpress.org/about/

/* translators: 1: https://wordpress.org/about/, 2: https://make.wordpress.org/ */
printf(
	__( 'WordPress is created by a <a href="%1$s">worldwide team</a> of passionate individuals. <a href="%2$s">Get involved in WordPress</a>.' ),
	'https://wordpress.org/about/',
	__( 'https://make.wordpress.org/' )
);

Replace to

/* translators: 1: https://wordpress.org/about/, 2: https://make.wordpress.org/ */
printf(
	__( 'WordPress is created by a <a href="%1$s">worldwide team</a> of passionate individuals. <a href="%2$s">Get involved in WordPress</a>.' ),
	__( 'https://wordpress.org/about/' ),
	__( 'https://make.wordpress.org/' )
);

Attachments (1)

46386.diff (554 bytes) - added by mukesh27 8 months ago.
Patch.

Download all attachments as: .zip

Change History (6)

@mukesh27
8 months ago

Patch.

#1 @tobifjellner
8 months ago

While at it: you should also add comments for translators just before each of the translatable URL:s.
/* translators: Give localized URL */

#2 @swissspidy
8 months ago

  • Summary changed from Missing translators need to be added in credits.php to Credits: Make WordPress.org URL translatable

@tobifjellner I don't think we usually do this.

#3 @tobifjellner
8 months ago

In most cases, it's just there in order to make it possible to adopt for the locale. In those cases where it's preferable to do it, a comment might be good.

#4 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.3

#5 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45659:

I18N: Make URLs to https://wordpress.org/about/ and related pages translatable, as they can now be localized on Rosetta sites.

Props mukesh27.
Fixes #46386.

Note: See TracTickets for help on using tickets.