#46410 closed defect (bug) (fixed)
Twenty Nineteen: Invalid check for twentynineteen_get_user_avatar_markup
Reported by: | Diego La Monica | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | dev-feedback has-patch good-first-bug |
Focuses: | template | Cc: |
Description
Hi all folks,
I've found a small bug in twentynineteen theme.
In file inc/template-tags.php @ row 169 the check for the function is wrong.
Indeed the nested function is twentynineteen_get_user_avatar_markup and not as wrongly reported twentynineteen_comment_avatar.
Follows the excerpt:
<?php if ( ! function_exists( 'twentynineteen_comment_avatar' ) ) : /** * Returns the HTML markup to generate a user avatar. */ function twentynineteen_get_user_avatar_markup( $id_or_email = null ) { if ( ! isset( $id_or_email ) ) { $id_or_email = get_current_user_id(); } return sprintf( '<div class="comment-user-avatar comment-author vcard">%s</div>', get_avatar( $id_or_email, twentynineteen_get_avatar_size() ) ); } endif;
Attachments (1)
Change History (8)
#2
@
6 years ago
- Component changed from Themes to Bundled Theme
- Keywords has-patch good-first-bug added; needs-patch removed
This ticket was mentioned in Slack in #core by sergey. View the logs.
5 years ago
#5
@
5 years ago
- Summary changed from Invalid check for twentynineteen_get_user_avatar_markup in twentynineteen to Twenty Nineteen: Invalid check for twentynineteen_get_user_avatar_markup
Note: See
TracTickets for help on using
tickets.
Hi @diego-la-monica, Welcome to WordPress Trac! Thanks for the report.
good caught it's small bug that will fix in next update.