Opened 6 years ago
Closed 6 years ago
#46444 closed defect (bug) (fixed)
"Scribd block" doesn't work with any url.
Reported by: | neobabis | Owned by: | manzoorwanijk |
---|---|---|---|
Milestone: | 5.2 | Priority: | normal |
Severity: | normal | Version: | 5.1 |
Component: | Embeds | Keywords: | good-first-bug has-patch commit |
Focuses: | Cc: |
Description
Describe the bug
I tried a lot of Scribd documents.
I copy the url of a Scribd document (not the shortcode) directly into a "Scribd block" but the return is "Sorry, we could not embed that content".
Urls is like: https://www.scribd.com/document/XXXnumbersXXX/TITLE-OF-DOCUMENT
To Reproduce
A solution is:
- Copy the Url https://www.scribd.com/document/XXXnumbersXXX/TITLE-OF-DOCUMENT
- Replace the word /document/ with /doc/
- Just paste the "new" Url to a Scribd block
But is this a real solution?
Screenshots
Attachments (2)
Change History (10)
#2
in reply to:
↑ 1
@
6 years ago
Replying to swissspidy:
Hi there and welcome to Trac!
Do you have an example URL that we could use to test this? Perhaps
https://www.scribd.com/document/...
is a new format added by the provider. Because looking at https://github.com/WordPress/wordpress-develop/blob/315616aa5ed76c12d35d9f6fe40dd179c93d430d/src/wp-includes/class-oembed.php#L63, we only support the/doc/
version.
Hi @swissspidy and community!
All Documents by Scribd have the same results because of /document/.
Testing Urls by a quick search:
https://www.scribd.com/document/238730976/Internship-Report-on-web-development
https://www.scribd.com/document/209045571/Web-Development-Proposal-Template
https://www.scribd.com/document/234070393/Web-Development-and-Design
#3
@
6 years ago
- Keywords needs-patch added; needs-testing removed
- Milestone changed from Awaiting Review to Future Release
Awesome, thanks!
I also just found an example on the https://oembed.com/ website:
The same example also works with the long format:
Sounds like an easy fix in WordPress to me :-)
#5
@
6 years ago
Best community ever :-)
Thank you for your quick reply!
I am waiting for a future release.
#6
@
6 years ago
- Keywords has-patch added; needs-patch removed
I have tested the patch with long URL format and it fixes the issue :)
Hi there and welcome to Trac!
Do you have an example URL that we could use to test this? Perhaps
https://www.scribd.com/document/...
is a new format added by the provider. Because looking at https://github.com/WordPress/wordpress-develop/blob/315616aa5ed76c12d35d9f6fe40dd179c93d430d/src/wp-includes/class-oembed.php#L63, we only support the/doc/
version.