WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 6 months ago

#46455 closed defect (bug) (fixed)

Twenty Nineteen: Remove duplicate function twentynineteen_is_comment_by_post_author from class TwentyNineteen_Walker_Comment

Reported by: mukesh27 Owned by: desrosj
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: Cc:
PR Number:

Description

Remove duplicate function twentynineteen_is_comment_by_post_author call from TwentyNineteen_Walker_Comment comment walker as both function print same svg icon output.

Attachments (1)

46455.diff (1.0 KB) - added by mukesh27 9 months ago.
Patch.

Download all attachments as: .zip

Change History (11)

@mukesh27
9 months ago

Patch.

#1 @mukesh27
7 months ago

#47102 was marked as a duplicate.

#2 @afercia
7 months ago

  • Milestone changed from Awaiting Review to 5.2.1

Looks like it was introduced in [44305] when merging the changes from the 5.0 branch into trunk. /Cc @laurelfulford @desrosj

#3 @desrosj
7 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 45297:

Twenty Nineteen: Remove duplicate code block.

Introduced in [44305].

Props mukesh27, afercia.
Fixes #46455.

#4 @desrosj
7 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport consideration.

#5 @ianbelanger
6 months ago

  • Milestone changed from 5.2.1 to 5.3

Changing milestone as Bundled Themes are only updated during major releases.

#6 @afercia
6 months ago

Changing milestone as Bundled Themes are only updated during major releases.

@ianbelanger I'm not sure this is entirely correct. Bundled themes did get updates during minor releases, for example this is the list of changes shipped in WordPress 5.0.2: https://core.trac.wordpress.org/query?status=closed&milestone=5.0.2&group=component and there are 17 changes related to Bundled Themes.

Would you mind to share some more details about why you think this and all the other tickets related to Twenty Nineteen should be moved to 5.3? Thank you.

#7 @ianbelanger
6 months ago

I discussed updating the Bundled Themes in minor releases with @laurelfulford earlier today. She brought up those updates in 5.0.2 as an example of when it has happened in the past, but she also said that they were exceptions. The only reason for those fixes in point releases, was because of the large number of changes to themes prior to 5.0 and Gutenberg.

Quoting @laurelfulford

Usually, (we only do bundled theme releases in majors) yeah, though there have been exceptions, like for not-great bugs — we did I think two theme updates on the two point releases after 5.0, to clean up Gutenberg issues, for example.

That’s kind of a weird case though — normally we don’t roll out so many changes to existing themes

I informed her of the milestone changes I made to this and the other Bundled Theme tickets and she was ok with it.

As a soon-to-be Bundled Theme Maintainer I'm personally not against updating a theme on a point release for site-breaking bugs, but none these seemed to meet that criteria.

#8 @afercia
6 months ago

Thanks for shedding some light on the milestone change.

not against updating a theme on a point release for site-breaking bugs, but none these seemed to meet that criteria.

At least a couple of them break accessibility. In the accessibility team we tend to consider these "site-breaking bugs" :) It's a bit unfortunate having to wait 5.3 to see them solved. /Cc @laurelfulford

#9 @desrosj
6 months ago

I'm going to close this out for now. It is marked fixed-major, so if a decision is made to release versions for bundled themes before 5.3, we can look for Bundled Theme tickets that were fixed-major and closed.

#10 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.