WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#46467 closed defect (bug) (fixed)

Update CrowdSignal oEmbed Regex

Reported by: kraftbj's profile kraftbj Owned by: johnbillion's profile johnbillion
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

In #45036 / [44484], the oembed for the survey.fm was added; however, these URLs could have subdomains. The regex should be updated to allow for this.

Example URL: ​https://kraftbj.survey.fm/core-example

cc: @doncha @pento

Attachments (2)

cs.diff​ (1.1 KB) - added by kraftbj 6 years ago.
cs.2.diff​ (1.1 KB) - added by kraftbj 6 years ago.
Update regex to match previous PollDaddy one.

Download all attachments as: .zip

Change History (6)

@kraftbj
6 years ago

This ticket was mentioned in ​Slack in #core-media by antpb. ​View the logs.
6 years ago

#2 @swissspidy
6 years ago

I'd probably use the same (.+\.)? pattern as for the Polldaddy URLs, but otherwise 👍

@kraftbj
6 years ago

Update regex to match previous PollDaddy one.

#3 @kraftbj
6 years ago

Updated to use the same style as the PollDaddy one.

#4 @johnbillion
6 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 45061:

Embeds: Update the Crowdsignal embed handler so that surveys on subdomains are supported.

Props kraftbj

Fixes #46467

Note: See TracTickets for help on using tickets.