WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 6 months ago

#46483 closed enhancement (fixed)

Eliminate use of date_default_timezone_set() for calculations in core

Reported by: Rarst Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: minor Version:
Component: Date/Time Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Core sets PHP timezone to UTC on boot and assumes it for Date/Time operations. Which we are in process of improving to eliminate reliance on this assumption in #44491

However there are also couple places in core where it changes PHP time zone back and forth for calculations:

  • in options to determine DST status
  • in PHPMailer (which I assume is just inherited from upstream)

We should get rid of these, calculations should not need to rely on manipulating global PHP configuration state.

Attachments (1)

settings-dst-detection.patch (973 bytes) - added by Rarst 7 months ago.

Download all attachments as: .zip

Change History (5)

This ticket was mentioned in Slack in #core-datetime by rarst. View the logs.


9 months ago

#2 @Rarst
7 months ago

  • Keywords has-patch added; needs-patch removed

#3 @SergeyBiryukov
7 months ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45556:

Date/Time: Eliminate use of date_default_timezone_set() for determining DST status on General Options screen.

Time calculations should not need to rely on manipulating global PHP configuration state.

Props Rarst.
Fixes #46483.

Note: See TracTickets for help on using tickets.