WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 5 months ago

Last modified 5 months ago

#46489 closed defect (bug) (fixed)

CSS line-height values should be unitless - admin-menu.css

Reported by: ianbelanger Owned by: ianbelanger
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit
Focuses: ui, administration, coding-standards Cc:

Description

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers wp-admin/css/admin-menu.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers

Attachments (2)

44643.admin-menu.css.diff (791 bytes) - added by ianbelanger 6 months ago.
46489.diff (791 bytes) - added by ianbelanger 6 months ago.
Adjusting patch name to new ticket number

Download all attachments as: .zip

Change History (9)

@ianbelanger
6 months ago

Adjusting patch name to new ticket number

#1 @netweb
6 months ago

  • Keywords good-first-bug removed
  • Milestone changed from Awaiting Review to 5.2

#2 @mukesh27
6 months ago

  • Keywords changed from has-patch, needs-testing to has-patch needs-testing

I tested this successfully without any error in Ubuntu 18.04.2 LTS with Google Chrome Version 73.0.3683.75 and Firefox Version 65.0.1

#3 @ianbelanger
6 months ago

  • Component changed from General to Administration

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


5 months ago

#5 @ianbelanger
5 months ago

  • Keywords commit added; needs-testing removed

#6 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45186:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/admin-menu.css.

Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46489. See #44643.

#7 @SergeyBiryukov
5 months ago

In 45187:

CSS Coding Standards: Use unitless values for line-height for count bubbles in wp-admin/css/admin-menu.css.

Missed in [45186].

Props ianbelanger.
See #46489, #44643.

Note: See TracTickets for help on using tickets.