WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 3 months ago

#46494 closed defect (bug) (fixed)

CSS line-height values should be unitless - customize-controls.css

Reported by: ianbelanger Owned by: ianbelanger
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch commit
Focuses: ui, administration, coding-standards Cc:

Description (last modified by ianbelanger)

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers much of wp-admin/css/customize-controls.css, see patch notes below

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers

Patch Notes:

Unchanged line-height values that use units (I could not find a good unitless solution that would work across all browsers and admin pages)

line 443 - #customize-controls .customize-pane-child .customize-section-title h3, #customize-controls .customize-pane-child h3.customize-section-title, #customize-outer-theme-controls .customize-pane-child .customize-section-title h3, #customize-outer-theme-controls .customize-pane-child h3.customize-section-title, #customize-controls .customize-info .panel-title
line 755 - .customize-section-title h3, h3.customize-section-title (This style is overidden by the above rule anyway and could probably be removed)
line 983 - .customize-control-color .color-picker, .customize-control-upload div
line 2900 - #available-widgets .customize-section-title h3, #available-menu-items .customize-section-title h3

Unable to find selectors anywhere in the DOM

line 1271 - .accordion-section .dropdown-content
line 1405 - .customize-control-header .inner, .customize-control-header .inner .dashicons
line 1869 - .control-section .customize-section-text-before

Attachments (1)

46494.diff (3.4 KB) - added by ianbelanger 4 months ago.

Download all attachments as: .zip

Change History (7)

@ianbelanger
4 months ago

#1 @ianbelanger
4 months ago

  • Description modified (diff)

#2 @netweb
4 months ago

  • Keywords good-first-bug removed
  • Milestone changed from Awaiting Review to 5.2

#3 @ianbelanger
4 months ago

  • Component changed from General to Customize
  • Keywords changed from has-patch, needs-testing to has-patch needs-testing

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 months ago

#5 @audrasjb
3 months ago

  • Keywords commit added; needs-testing removed

@ianbelanger I tested the patch and it looks good on my side. That was not easy to test all the fields of the customizer but I managed to simulate the ones that I can't test directly with any of the bundle themes :-)

#6 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45189:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-controls.css.

Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46494. See #44643.

Note: See TracTickets for help on using tickets.