Opened 6 years ago
Closed 6 years ago
#46500 closed enhancement (fixed)
Performs minor code improvements in abstract-testcase.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.2 | Priority: | normal |
Severity: | normal | Version: | 5.2 |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | Cc: |
Description
I've done some minor code improvements to make the code in abstract-testcase a little bit better:
- Added
TRUE
as third argument forin_array
checks - Used
strpos
instead ofsubstr
where possible - Add value directly to array by key instead of
array_push
- Removed an else statement because the if already returns a value.
I hope these changes are desirable. I would love to hear this, because I can continue performing equal changes elsewhere in the testing framework.
Attachments (1)
Change History (3)
Note: See
TracTickets for help on using
tickets.
In 44916: