WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#46503 closed enhancement (fixed)

Docs: Added description for global $post

Reported by: immeet94's profile immeet94 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch
Focuses: docs, coding-standards Cc:

Description

In many core files document of global $post id not added.

Attachments (2)

#46503.diff​ (3.3 KB) - added by immeet94 6 years ago.
Patch
#46503.2.diff​ (2.2 KB) - added by immeet94 6 years ago.
Please see this file for updated patch.

Download all attachments as: .zip

Change History (10)

@immeet94
6 years ago

Patch

@immeet94
6 years ago

Please see this file for updated patch.

This ticket was mentioned in ​Slack in #core by immeet94. ​View the logs.
5 years ago

#2 @SergeyBiryukov
5 years ago

  • Component changed from General to Posts, Post Types
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

This ticket was mentioned in ​Slack in #core by immeet94. ​View the logs.
5 years ago

#4 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.3

#5 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45742:

Docs: Add missing description for $post global.

Props immeet94.
Fixes #46503. See #47110.

#6 @SergeyBiryukov
5 years ago

In 45744:

Posts, Post Types: Revert unintended change from [45742].

See #46503.

#7 follow-up: @diddledani
5 years ago

@SergeyBiryukov in 45744 you reverted a change that was actually correct, though maybe not necessary for this issue. delete_option() expects 1 parameter but the reinstated call in 45744 passes 2 parameters. The correct usage is to drop the second parameter.

#8 in reply to: ↑ 7 @SergeyBiryukov
5 years ago

Replying to diddledan:

delete_option() expects 1 parameter but the reinstated call in 45744 passes 2 parameters.

Thanks! Yes, just wanted to handle that in #46850 :)

Note: See TracTickets for help on using tickets.