WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#46507 closed enhancement (fixed)

Grammar mistake in info comment

Reported by: umang7 Owned by: SergeyBiryukov
Priority: normal Milestone: 5.2
Component: Filesystem API Version:
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description

There is grammar mistake.

Attachments (2)

mistakes.diff​ (1.1 KB ) - added by umang7 8 years ago.
46507.diff​ (2.4 KB ) - added by mukesh27 8 years ago.
Added missing @since 2.5 to @since 2.5.0 inn class-ftp.php file

Download all attachments as: .zip

Change History (5)

@umang7
8 years ago

#1 @SergeyBiryukov
8 years ago

  • Component General → Filesystem API
  • Focuses docs added
  • Milestone Awaiting Review → 5.2
  • Owner set to SergeyBiryukov
  • Status new → reviewing

Hi @umang7, welcome to WordPress Trac! Thanks for the patch.

These files were initially an external library, however more than 20 commits have been made to them over the years, so I don't see any reason not to fix this.

While we're at it, let's also change @since 2.5 to @since 2.5.0, per the ​documentation standards. [26868] did this for class-ftp-pure.php and class-ftp-sockets.php, however class-ftp.php was missed.

@mukesh27
8 years ago

Added missing @since 2.5 to @since 2.5.0 inn class-ftp.php file

#2 @SergeyBiryukov
8 years ago

In 44919:

Docs: Use 3-digit, x.x.x style semantic versioning for @since 2.5.0 entries in wp-admin/includes/class-ftp.php.

Missed in [26868].

Props mukesh27.
See #46507.

#3 @SergeyBiryukov
8 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 44920:

Docs: Correct grammar in PemFTP description.

Props umang7.
Fixes #46507.

Note: See TracTickets for help on using tickets.