Opened 6 years ago
Closed 6 years ago
#46510 closed defect (bug) (fixed)
CSS line-height values should be unitless - dashboard.css
Reported by: | ianbelanger | Owned by: | ianbelanger |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-patch needs-testing good-first-bug |
Focuses: | ui, administration, coding-standards | Cc: |
Description
As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value
. It was suggested that we break up 44643 by stylesheet in order to better track them.
This ticket covers much of wp-admin/css/dashboard.css
, see patch notes below
Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.
Patch Notes:
Unable to find selectors in the DOM
line 471 - #dashboard_php_nag .button .dashicons-external (not sure how to trigger php nag)
Attachments (2)
Change History (5)
Note: See
TracTickets for help on using
tickets.
Updates patch with more precise line-height calculations