Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 7 years ago

Closed 7 years ago

#46516 closed defect (bug) (fixed)

CSS line-height values should be unitless - nav-menus.css

Reported by:	ianbelanger	Owned by:	audrasjb
Priority:	normal	Milestone:	5.3
Component:	Menus	Version:
Severity:	normal	Keywords:	has-patch good-first-bug commit
Cc:		Focuses:	ui, administration, coding-standards

Description

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers wp-admin/css/nav-menus.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Attachments (3)

46516.diff (1.6 KB ) - added by ianbelanger 7 years ago.
46516.2.diff (1.9 KB ) - added by audrasjb 7 years ago.: Patch refresh
46516.3.diff (966 bytes ) - added by ianbelanger 7 years ago.: Updates patch with more precise line-height calculations

Download all attachments as: .zip

Change History (9)

@ianbelanger
7 years ago

Attachment 46516.diff added

#1 @audrasjb
7 years ago

Owner changed from ianbelanger to audrasjb
Status assigned → reviewing

@audrasjb
7 years ago

Attachment 46516.2.diff added

Patch refresh

#2 @audrasjb
7 years ago

Component General → Menus
Keywords needs-testing removed
Milestone Awaiting Review → 5.2

Thanks @ianbelanger
I refreshed the patch against trunk :-)

Tested on my side and I think it's good to go!

#3 @audrasjb
7 years ago

Keywords commit added
Status reviewing → accepted

#4 @SergeyBiryukov
7 years ago

Resolution → fixed
Status accepted → closed

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/nav-menus.css.

Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.

@ianbelanger
7 years ago

Attachment 46516.3.diff added

Updates patch with more precise line-height calculations

#5 @ianbelanger
7 years ago

Milestone 5.2 → 5.3
Resolution fixed
Status closed → reopened

#6 @SergeyBiryukov
7 years ago

Resolution → fixed
Status reopened → closed

CSS Coding Standards: Update unitless values for line-height in wp-admin/css/nav-menus.css with more precise calculations.

Props ianbelanger.
Fixes #46516.

Note: See TracTickets for help on using tickets.

Download in other formats: