WordPress.org

Make WordPress Core

Opened 6 weeks ago

Closed 2 weeks ago

#46516 closed defect (bug) (fixed)

CSS line-height values should be unitless - nav-menus.css

Reported by: ianbelanger Owned by: audrasjb
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch good-first-bug commit
Focuses: ui, administration, coding-standards Cc:

Description

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers wp-admin/css/nav-menus.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Attachments (2)

46516.diff (1.6 KB) - added by ianbelanger 6 weeks ago.
46516.2.diff (1.9 KB) - added by audrasjb 4 weeks ago.
Patch refresh

Download all attachments as: .zip

Change History (6)

@ianbelanger
6 weeks ago

#1 @audrasjb
4 weeks ago

  • Owner changed from ianbelanger to audrasjb
  • Status changed from assigned to reviewing

@audrasjb
4 weeks ago

Patch refresh

#2 @audrasjb
4 weeks ago

  • Component changed from General to Menus
  • Keywords needs-testing removed
  • Milestone changed from Awaiting Review to 5.2

Thanks @ianbelanger
I refreshed the patch against trunk :-)

Tested on my side and I think it's good to go!

#3 @audrasjb
4 weeks ago

  • Keywords commit added
  • Status changed from reviewing to accepted

#4 @SergeyBiryukov
2 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 45123:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/nav-menus.css.

Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.

Note: See TracTickets for help on using tickets.