WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#46516 closed defect (bug) (fixed)

CSS line-height values should be unitless - nav-menus.css

Reported by: ianbelanger's profile ianbelanger Owned by: audrasjb's profile audrasjb
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch good-first-bug commit
Focuses: ui, administration, coding-standards Cc:

Description

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers wp-admin/css/nav-menus.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Attachments (3)

46516.diff​ (1.6 KB) - added by ianbelanger 6 years ago.
46516.2.diff​ (1.9 KB) - added by audrasjb 6 years ago.
Patch refresh
46516.3.diff​ (966 bytes) - added by ianbelanger 5 years ago.
Updates patch with more precise line-height calculations

Download all attachments as: .zip

Change History (9)

@ianbelanger
6 years ago

#1 @audrasjb
6 years ago

  • Owner changed from ianbelanger to audrasjb
  • Status changed from assigned to reviewing

@audrasjb
6 years ago

Patch refresh

#2 @audrasjb
6 years ago

  • Component changed from General to Menus
  • Keywords needs-testing removed
  • Milestone changed from Awaiting Review to 5.2

Thanks @ianbelanger
I refreshed the patch against trunk :-)

Tested on my side and I think it's good to go!

#3 @audrasjb
6 years ago

  • Keywords commit added
  • Status changed from reviewing to accepted

#4 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 45123:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/nav-menus.css.

Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.

@ianbelanger
5 years ago

Updates patch with more precise line-height calculations

#5 @ianbelanger
5 years ago

  • Milestone changed from 5.2 to 5.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

#6 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45414:

CSS Coding Standards: Update unitless values for line-height in wp-admin/css/nav-menus.css with more precise calculations.

Props ianbelanger.
Fixes #46516.

Note: See TracTickets for help on using tickets.