WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#46518 closed defect (bug) (fixed)

CSS line-height values should be unitless - themes.css

Reported by: ianbelanger's profile ianbelanger Owned by: ianbelanger's profile ianbelanger
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch good-first-bug commit
Focuses: ui, administration, coding-standards Cc:

Description

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers wp-admin/css/themes.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Attachments (1)

46518.diff​ (1.7 KB) - added by ianbelanger 6 years ago.

Download all attachments as: .zip

Change History (6)

@ianbelanger
6 years ago

#1 @ianbelanger
6 years ago

  • Component changed from General to Themes
  • Milestone changed from Awaiting Review to 5.2

#2 @mukesh27
6 years ago

I tested this successfully without any error in Ubuntu 18.04.2 LTS with Google Chrome Version 73.0.3683.75 and Firefox Version 65.0.1

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
6 years ago

#4 @audrasjb
6 years ago

  • Keywords commit added; needs-testing removed

Tested on Mac OS X on Chrome and Firefox (up-to-date versions). Good to go!

#5 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45188:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/themes.css.

Props ianbelanger, mukesh27, audrasjb, pbiron, afercia.
Fixes #46518. See #44643.

Note: See TracTickets for help on using tickets.