WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 4 months ago

#46526 closed defect (bug) (fixed)

CSS line-height values should be unitless - buttons.css

Reported by: ianbelanger Owned by: ianbelanger
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch needs-testing good-first-bug
Focuses: ui, administration, coding-standards Cc:

Description (last modified by ianbelanger)

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers much of wp-includes/css/buttons.css, see patch notes below

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Patch Notes:

Unable to find selectors in the DOM. It appears that this particular selector no longer exists in core

line 360 - #media-upload.wp-core-ui .button

Attachments (2)

46526.diff (1.2 KB) - added by ianbelanger 6 months ago.
46526.1.diff (1.3 KB) - added by ianbelanger 5 months ago.
Updates patch with more precise line-height calculations

Download all attachments as: .zip

Change History (7)

@ianbelanger
6 months ago

#1 @ianbelanger
6 months ago

  • Description modified (diff)

#2 @ianbelanger
6 months ago

  • Milestone changed from Awaiting Review to Future Release

#3 @mukesh27
5 months ago

I tested attached patch successfully without any error in Ubuntu 18.04.2 LTS with Google Chrome Version 73.0.3683.75 and Firefox Version 65.0.1

@ianbelanger
5 months ago

Updates patch with more precise line-height calculations

#4 @ianbelanger
4 months ago

  • Milestone changed from Future Release to 5.3

#5 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45476:

CSS Coding Standards: Use unitless values for line-height in wp-includes/css/buttons.css.

Props ianbelanger, pbiron, afercia.
Fixes #46526. See #44643.

Note: See TracTickets for help on using tickets.