WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 4 months ago

#46528 closed defect (bug) (fixed)

CSS line-height values should be unitless - editor.css

Reported by: ianbelanger Owned by: ianbelanger
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch needs-testing good-first-bug
Focuses: ui, administration, coding-standards Cc:

Description (last modified by ianbelanger)

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers much of wp-includes/css/editor.css, see patch notes below

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Patch Notes:

Unable to find selectors in the DOM. These may no longer exist in Core, but I am not 100% sure about that.

line 57 - .mce-window .mce-window-head .mce-title
line 70 - .mce-window .mce-window-head .mce-close, .mce-window-head .mce-close .mce-i-remove
line 228 - .mce-menu-has-icons i.mce-ico
line 242 - div.mce-tab
line 686 - .mce-window .mce-btn
line 848 - .mce-toolbar .mce-btn .mce-open

Would love to get confirmation of this from someone with intimate knowledge of Core TinyMCE.

Attachments (2)

46528.diff (1.7 KB) - added by ianbelanger 6 months ago.
46528.1.diff (1.8 KB) - added by ianbelanger 5 months ago.
Updates patch with more precise line-height calculations

Download all attachments as: .zip

Change History (6)

@ianbelanger
6 months ago

#1 @ianbelanger
6 months ago

  • Description modified (diff)

#2 @ianbelanger
6 months ago

  • Component changed from General to Editor
  • Milestone changed from Awaiting Review to Future Release

@ianbelanger
5 months ago

Updates patch with more precise line-height calculations

#3 @ianbelanger
4 months ago

  • Milestone changed from Future Release to 5.3

#4 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45477:

CSS Coding Standards: Use unitless values for line-height in wp-includes/css/editor.css.

Props ianbelanger, pbiron, afercia.
Fixes #46528. See #44643.

Note: See TracTickets for help on using tickets.