CSS line-height values should be unitless - media-views.css

[ianbelanger]

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers much of wp-includes/css/media-views.css, see patch notes below

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Patch Notes:

Unable to find selectors in the DOM. These may no longer exist in Core, but I am not 100% sure about that.

line 328 - .media-sidebar .sidebar-title
line 1139 - .attachments-browser .instructions

[joemcgill]

Hi @ianbelanger. I'd be happy to see this change land. Thanks for the patch!

[mukesh27]

I tested attached patch successfully without any error in Ubuntu 18.04.2 LTS with Google Chrome Version 73.0.3683.75 and Firefox Version 65.0.1

[ianbelanger]

Updates patch with more precise line-height calculations

[SergeyBiryukov]

In 45478:

CSS Coding Standards: Use unitless values for line-height in wp-includes/css/media-views.css.

Props ianbelanger, pbiron, afercia.
Fixes #46529. See #44643.

[afercia]

line 328 - .media-sidebar .sidebar-title
line 1139 - .attachments-browser .instructions

.attachments-browser .instructions is still used for the instructions that appear in the edit gallery view, edit playlist view, and for example in the Customizer when setting a header image. See attached screenshot.

Re: .media-sidebar .sidebar-title after some software archeology, I think it's a leftover, as well as sidebar-content and .media-sidebar .search and these rules can be safely removed.

They were introduced in [22321] for the first implementation of the media sidebar. Then removed right after in [22362]. Also, as far as I can tell there's no search in the sidebar.

[ianbelanger]

Update for last line-height change

[ianbelanger]

46529.2.diff addresses .attachments-browser .instructions, but I could not locate .media-sidebar .sidebar-title, sidebar-content or .media-sidebar .search in media-views.css

Thanks for pointing that out @afercia

[SergeyBiryukov]

Replying to ianbelanger:

46529.2.diff addresses .attachments-browser .instructions, but I could not locate .media-sidebar .sidebar-title, sidebar-content or .media-sidebar .search in media-views.css

Right, they were removed in [45499].

[SergeyBiryukov]

In 46431:

CSS Coding Standards: Use unitless values for line-height in wp-includes/css/media-views.css.

Follow-up to [45478].

Props ianbelanger, afercia.
Fixes #46529. See #44643.